threads / patch / 48785

patch, 2 partsgitignore.txt: clarify default core.excludesfile path

Subject: [PATCH 1/2] gitignore.txt: clarify default core.excludesfile path

## tl;dr

4 messages between Jun 27, 2018 and Jun 27, 2018. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Todd Zullinger· Jun 27, 2018, 04:46 UTC · lore

The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore. $HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset, as described later in the document.

Signed-off-by: Todd Zullinger <tmz@pobox.com>
---
 Documentation/gitignore.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to Documentation/gitignore.txt +1 −1

diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index ff5d7f9ed6..d107daaffd 100644
--- a/Documentation/gitignore.txt
+++ b/Documentation/gitignore.txt
@@ -7,7 +7,7 @@ gitignore - Specifies intentionally untracked files to ignore
 
 SYNOPSIS
 --------
-$HOME/.config/git/ignore, $GIT_DIR/info/exclude, .gitignore
+$XDG_CONFIG_HOME/git/ignore, $GIT_DIR/info/exclude, .gitignore
 
 DESCRIPTION
 -----------

-- 
2.18.0

Todd Zullinger· Jun 27, 2018, 04:46 UTC · re: Todd Zullinger · lore

[PATCH 2/2] dir.c: fix typos in core.excludesfile comment

Make it easier to find references to core.excludesfile and the default $XDG_CONFIG_HOME/git/ignore path.

Signed-off-by: Todd Zullinger <tmz@pobox.com>
---
I noticed the typo in core.excludesfile and $XDG_CONFIG_HOME while I was
verifing the previous change to clarify the documentation matched the code.
Fixing these minor issues in the comments will hopefully make it easier for
others to find the right places in the code in the future.

 dir.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to dir.c +1 −1

diff --git a/dir.c b/dir.c
index fe9bf58e4c..363a4837ae 100644
--- a/dir.c
+++ b/dir.c
@@ -2497,7 +2497,7 @@ void setup_standard_excludes(struct dir_struct *dir)
 {
 	dir->exclude_per_dir = ".gitignore";
 
-	/* core.excludefile defaulting to $XDG_HOME/git/ignore */
+	/* core.excludesfile defaulting to $XDG_CONFIG_HOME/git/ignore */
 	if (!excludes_file)
 		excludes_file = xdg_config_home("ignore");
 	if (excludes_file && !access_or_warn(excludes_file, R_OK, 0))

-- 
2.18.0

Junio C Hamano· Jun 27, 2018, 19:16 UTC · re: Todd Zullinger · lore

Re: [PATCH 1/2] gitignore.txt: clarify default core.excludesfile path

Todd Zullinger <tmz@pobox.com> writes:

> The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore.
> $HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset,

... because $HOME/.config is the default value for XDG_CONFIG_HOME when it is unset, that is? If so, the change makes sense.

> as described later in the document.

Show 18 quoted lines

> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
>  Documentation/gitignore.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
> index ff5d7f9ed6..d107daaffd 100644
> --- a/Documentation/gitignore.txt
> +++ b/Documentation/gitignore.txt
> @@ -7,7 +7,7 @@ gitignore - Specifies intentionally untracked files to ignore
>  
>  SYNOPSIS
>  --------
> -$HOME/.config/git/ignore, $GIT_DIR/info/exclude, .gitignore
> +$XDG_CONFIG_HOME/git/ignore, $GIT_DIR/info/exclude, .gitignore
>  
>  DESCRIPTION
>  -----------

Todd Zullinger· Jun 27, 2018, 20:07 UTC · re: Junio C Hamano · lore

Re: [PATCH 1/2] gitignore.txt: clarify default core.excludesfile path

Junio C Hamano wrote:

Show 7 quoted lines

> Todd Zullinger <tmz@pobox.com> writes:
> 
>> The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore.
>> $HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset,
> 
> ... because $HOME/.config is the default value for XDG_CONFIG_HOME
> when it is unset, that is?  If so, the change makes sense.

Indeed, that's the fallback path.

Thanks,

-- 
Todd