{"thread":{"id":"48785","subject":"[PATCH 1/2] gitignore.txt: clarify default core.excludesfile path","startedAt":"2018-06-27T04:46:59Z","lastAt":"2018-06-27T20:07:49Z","messageCount":4,"participants":["Todd Zullinger","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"351059","messageId":"20180627044652.12080-1-tmz@pobox.com","threadId":"48785","inReplyTo":null,"subject":"[PATCH 1/2] gitignore.txt: clarify default core.excludesfile path","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2018-06-27T04:46:51Z","receivedAt":"2018-06-27T04:46:59Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore.\n$HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset,\nas described later in the document.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\n---\n Documentation/gitignore.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt\nindex ff5d7f9ed6..d107daaffd 100644\n--- a/Documentation/gitignore.txt\n+++ b/Documentation/gitignore.txt\n@@ -7,7 +7,7 @@ gitignore - Specifies intentionally untracked files to ignore\n \n SYNOPSIS\n --------\n-$HOME/.config/git/ignore, $GIT_DIR/info/exclude, .gitignore\n+$XDG_CONFIG_HOME/git/ignore, $GIT_DIR/info/exclude, .gitignore\n \n DESCRIPTION\n -----------\n-- \n2.18.0\n\n"},{"id":"351060","messageId":"20180627044652.12080-2-tmz@pobox.com","threadId":"48785","inReplyTo":"20180627044652.12080-1-tmz@pobox.com","subject":"[PATCH 2/2] dir.c: fix typos in core.excludesfile comment","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2018-06-27T04:46:52Z","receivedAt":"2018-06-27T04:47:00Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Make it easier to find references to core.excludesfile and the default\n$XDG_CONFIG_HOME/git/ignore path.\n\nSigned-off-by: Todd Zullinger <tmz@pobox.com>\n---\nI noticed the typo in core.excludesfile and $XDG_CONFIG_HOME while I was\nverifing the previous change to clarify the documentation matched the code.\nFixing these minor issues in the comments will hopefully make it easier for\nothers to find the right places in the code in the future.\n\n dir.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/dir.c b/dir.c\nindex fe9bf58e4c..363a4837ae 100644\n--- a/dir.c\n+++ b/dir.c\n@@ -2497,7 +2497,7 @@ void setup_standard_excludes(struct dir_struct *dir)\n {\n \tdir->exclude_per_dir = \".gitignore\";\n \n-\t/* core.excludefile defaulting to $XDG_HOME/git/ignore */\n+\t/* core.excludesfile defaulting to $XDG_CONFIG_HOME/git/ignore */\n \tif (!excludes_file)\n \t\texcludes_file = xdg_config_home(\"ignore\");\n \tif (excludes_file && !access_or_warn(excludes_file, R_OK, 0))\n-- \n2.18.0\n\n"},{"id":"351154","messageId":"xmqqvaa4dopx.fsf@gitster-ct.c.googlers.com","threadId":"48785","inReplyTo":"20180627044652.12080-1-tmz@pobox.com","subject":"Re: [PATCH 1/2] gitignore.txt: clarify default core.excludesfile path","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2018-06-27T19:16:42Z","receivedAt":"2018-06-27T19:16:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Todd Zullinger <tmz@pobox.com> writes:\n\n> The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore.\n> $HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset,\n\n... because $HOME/.config is the default value for XDG_CONFIG_HOME\nwhen it is unset, that is?  If so, the change makes sense.\n\n> as described later in the document.\n\n\n\n> Signed-off-by: Todd Zullinger <tmz@pobox.com>\n> ---\n>  Documentation/gitignore.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt\n> index ff5d7f9ed6..d107daaffd 100644\n> --- a/Documentation/gitignore.txt\n> +++ b/Documentation/gitignore.txt\n> @@ -7,7 +7,7 @@ gitignore - Specifies intentionally untracked files to ignore\n>  \n>  SYNOPSIS\n>  --------\n> -$HOME/.config/git/ignore, $GIT_DIR/info/exclude, .gitignore\n> +$XDG_CONFIG_HOME/git/ignore, $GIT_DIR/info/exclude, .gitignore\n>  \n>  DESCRIPTION\n>  -----------\n"},{"id":"351158","messageId":"20180627200743.GL20217@zaya.teonanacatl.net","threadId":"48785","inReplyTo":"xmqqvaa4dopx.fsf@gitster-ct.c.googlers.com","subject":"Re: [PATCH 1/2] gitignore.txt: clarify default core.excludesfile path","fromName":"Todd Zullinger","fromEmail":"tmz@pobox.com","sentAt":"2018-06-27T20:07:43Z","receivedAt":"2018-06-27T20:07:49Z","isPatch":true,"sender":{"key":"tmz@pobox.com","avatar":"https://avatars.githubusercontent.com/u/806319?v=4"},"body":"Junio C Hamano wrote:\n> Todd Zullinger <tmz@pobox.com> writes:\n> \n>> The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore.\n>> $HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset,\n> \n> ... because $HOME/.config is the default value for XDG_CONFIG_HOME\n> when it is unset, that is?  If so, the change makes sense.\n\nIndeed, that's the fallback path.\n\nThanks,\n\n-- \nTodd\n"}]}