threads / patch / 48635

patchsha1-file.c: Correct $GITDIR to $GIT_DIR

Subject: [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR

## tl;dr

2 messages between Jun 3, 2018 and Jun 3, 2018. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Robert P. J. Day· Jun 3, 2018, 12:22 UTC · lore

Fix single misspelling of $GITDIR to correct $GIT_DIR.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

only occurrence in entire code base that i ran across, so i figured might as well fix it.

Show changes to sha1-file.c +1 −1

diff --git a/sha1-file.c b/sha1-file.c
index 555e780f4..695e5c627 100644
--- a/sha1-file.c
+++ b/sha1-file.c
@@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)
 /*
  * Compute the exact path an alternate is at and returns it. In case of
  * error NULL is returned and the human readable error is added to `err`
- * `path` may be relative and should point to $GITDIR.
+ * `path` may be relative and should point to $GIT_DIR.
  * `err` must not be null.
  */
 char *compute_alternate_path(const char *path, struct strbuf *err)

-- 
========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                  http://crashcourse.ca/dokuwiki

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

SZEDER Gábor· Jun 3, 2018, 14:29 UTC · re: Robert P. J. Day · lore

Re: [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR

Could you please add "in a comment" to the end of the subject line? So it will be immediately clear to future readers of 'git log --oneline' that this is not a bugfix.

Show 22 quoted lines

> Fix single misspelling of $GITDIR to correct $GIT_DIR.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
> only occurrence in entire code base that i ran across, so i figured
> might as well fix it.
> 
> diff --git a/sha1-file.c b/sha1-file.c
> index 555e780f4..695e5c627 100644
> --- a/sha1-file.c
> +++ b/sha1-file.c
> @@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)
>  /*
>   * Compute the exact path an alternate is at and returns it. In case of
>   * error NULL is returned and the human readable error is added to `err`
> - * `path` may be relative and should point to $GITDIR.
> + * `path` may be relative and should point to $GIT_DIR.
>   * `err` must not be null.
>   */
>  char *compute_alternate_path(const char *path, struct strbuf *err)