{"thread":{"id":"48635","subject":"[PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR","startedAt":"2018-06-03T12:24:24Z","lastAt":"2018-06-03T14:29:26Z","messageCount":2,"participants":["Robert P. J. Day","SZEDER Gábor"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"349139","messageId":"alpine.LFD.2.21.1806030820180.14575@localhost.localdomain","threadId":"48635","inReplyTo":null,"subject":"[PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR","fromName":"Robert P. J. Day","fromEmail":"rpjday@crashcourse.ca","sentAt":"2018-06-03T12:22:11Z","receivedAt":"2018-06-03T12:24:24Z","isPatch":true,"sender":{"key":"rpjday@crashcourse.ca","avatar":"https://avatars.githubusercontent.com/u/226084077?v=4"},"body":"Fix single misspelling of $GITDIR to correct $GIT_DIR.\n\nSigned-off-by: Robert P. J. Day <rpjday@crashcourse.ca>\n\n---\n\nonly occurrence in entire code base that i ran across, so i figured\nmight as well fix it.\n\ndiff --git a/sha1-file.c b/sha1-file.c\nindex 555e780f4..695e5c627 100644\n--- a/sha1-file.c\n+++ b/sha1-file.c\n@@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)\n /*\n  * Compute the exact path an alternate is at and returns it. In case of\n  * error NULL is returned and the human readable error is added to `err`\n- * `path` may be relative and should point to $GITDIR.\n+ * `path` may be relative and should point to $GIT_DIR.\n  * `err` must not be null.\n  */\n char *compute_alternate_path(const char *path, struct strbuf *err)\n\n\n-- \n\n========================================================================\nRobert P. J. Day                                 Ottawa, Ontario, CANADA\n                  http://crashcourse.ca/dokuwiki\n\nTwitter:                                       http://twitter.com/rpjday\nLinkedIn:                               http://ca.linkedin.com/in/rpjday\n========================================================================\n"},{"id":"349145","messageId":"20180603142910.6211-1-szeder.dev@gmail.com","threadId":"48635","inReplyTo":"alpine.LFD.2.21.1806030820180.14575@localhost.localdomain","subject":"Re: [PATCH] sha1-file.c: Correct $GITDIR to $GIT_DIR","fromName":"SZEDER Gábor","fromEmail":"szeder.dev@gmail.com","sentAt":"2018-06-03T14:29:10Z","receivedAt":"2018-06-03T14:29:26Z","isPatch":true,"sender":{"key":"szeder.dev@gmail.com","avatar":"https://avatars.githubusercontent.com/u/116324?v=4"},"body":"Could you please add \"in a comment\" to the end of the subject line?\nSo it will be immediately clear to future readers of 'git log\n--oneline' that this is not a bugfix.\n\n> Fix single misspelling of $GITDIR to correct $GIT_DIR.\n> \n> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>\n> \n> ---\n> \n> only occurrence in entire code base that i ran across, so i figured\n> might as well fix it.\n> \n> diff --git a/sha1-file.c b/sha1-file.c\n> index 555e780f4..695e5c627 100644\n> --- a/sha1-file.c\n> +++ b/sha1-file.c\n> @@ -610,7 +610,7 @@ void add_to_alternates_memory(const char *reference)\n>  /*\n>   * Compute the exact path an alternate is at and returns it. In case of\n>   * error NULL is returned and the human readable error is added to `err`\n> - * `path` may be relative and should point to $GITDIR.\n> + * `path` may be relative and should point to $GIT_DIR.\n>   * `err` must not be null.\n>   */\n>  char *compute_alternate_path(const char *path, struct strbuf *err)\n"}]}