t5318-commit-graph.sh breaks travis gettext poison job

Duy Nguyen· Jun 1, 2018, 16:17 UTC · lore

In case you're not checking travis, [1] reports

Test Summary Report
-------------------
t5318-commit-graph.sh                            (Wstat: 256 Tests: 62
Failed: 2)
  Failed tests:  61-62
  Non-zero exit status: 1

This usually means you're grepping an i18n string

[1] https://travis-ci.org/git/git/jobs/386532326

-- 
Duy

Derrick Stolee· Jun 1, 2018, 17:16 UTC · re: Duy Nguyen · lore

Re: t5318-commit-graph.sh breaks travis gettext poison job

On 6/1/2018 12:17 PM, Duy Nguyen wrote:

Show 13 quoted lines

> In case you're not checking travis, [1] reports
>
> Test Summary Report
> -------------------
> t5318-commit-graph.sh                            (Wstat: 256 Tests: 62
> Failed: 2)
>    Failed tests:  61-62
>    Non-zero exit status: 1
>
> This usually means you're grepping an i18n string
>
> [1] https://travis-ci.org/git/git/jobs/386532326
>

Thanks, Duy. I believe this is related to the place Szeder pointed out [1] with the one translatable string in verify_commit_graph().

I've fixed this in my local branch, and plan to push v4 when review of v3 is complete.

Thanks, -Stolee

[1] 
https://public-inbox.org/git/20180530123529.32090-1-szeder.dev@gmail.com/
     Re: [PATCH v3 16/20] commit-graph: verify contents match checksum