{"thread":{"id":"48625","subject":"t5318-commit-graph.sh breaks travis gettext poison job","startedAt":"2018-06-01T16:18:30Z","lastAt":"2018-06-01T17:16:18Z","messageCount":2,"participants":["Duy Nguyen","Derrick Stolee"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"349003","messageId":"CACsJy8CRgkyjcpK3FPaF7mrAuEFjGOShNjBZgjgrshg365T3Rw@mail.gmail.com","threadId":"48625","inReplyTo":null,"subject":"t5318-commit-graph.sh breaks travis gettext poison job","fromName":"Duy Nguyen","fromEmail":"pclouds@gmail.com","sentAt":"2018-06-01T16:17:56Z","receivedAt":"2018-06-01T16:18:30Z","isPatch":false,"sender":{"key":"pclouds@gmail.com","avatar":"https://avatars.githubusercontent.com/u/720?v=4"},"body":"In case you're not checking travis, [1] reports\n\nTest Summary Report\n-------------------\nt5318-commit-graph.sh                            (Wstat: 256 Tests: 62\nFailed: 2)\n  Failed tests:  61-62\n  Non-zero exit status: 1\n\nThis usually means you're grepping an i18n string\n\n[1] https://travis-ci.org/git/git/jobs/386532326\n\n-- \nDuy\n"},{"id":"349004","messageId":"e3181d02-34cc-fbfb-367b-1d9172930c10@gmail.com","threadId":"48625","inReplyTo":"CACsJy8CRgkyjcpK3FPaF7mrAuEFjGOShNjBZgjgrshg365T3Rw@mail.gmail.com","subject":"Re: t5318-commit-graph.sh breaks travis gettext poison job","fromName":"Derrick Stolee","fromEmail":"stolee@gmail.com","sentAt":"2018-06-01T17:16:09Z","receivedAt":"2018-06-01T17:16:18Z","isPatch":false,"sender":{"key":"stolee@gmail.com","avatar":"https://avatars.githubusercontent.com/u/570044?v=4"},"body":"On 6/1/2018 12:17 PM, Duy Nguyen wrote:\n> In case you're not checking travis, [1] reports\n>\n> Test Summary Report\n> -------------------\n> t5318-commit-graph.sh                            (Wstat: 256 Tests: 62\n> Failed: 2)\n>    Failed tests:  61-62\n>    Non-zero exit status: 1\n>\n> This usually means you're grepping an i18n string\n>\n> [1] https://travis-ci.org/git/git/jobs/386532326\n>\n\nThanks, Duy. I believe this is related to the place Szeder pointed out \n[1] with the one translatable string in verify_commit_graph().\n\nI've fixed this in my local branch, and plan to push v4 when review of \nv3 is complete.\n\nThanks,\n-Stolee\n\n[1] \nhttps://public-inbox.org/git/20180530123529.32090-1-szeder.dev@gmail.com/\n     Re: [PATCH v3 16/20] commit-graph: verify contents match checksum\n"}]}