threads / patch / 48290

patcht1510-repo-setup.sh: rm useless mkdir

Subject: [PATCH] t1510-repo-setup.sh: rm useless mkdir

## tl;dr

2 messages between Apr 15, 2018 and Apr 16, 2018. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

qingyunha@foxmail.com· Apr 15, 2018, 02:45 UTC · lore
From: Tao Qingyun <845767657@qq.com>
Signed-off-by: Tao Qingyun <845767657@qq.com>
---
 t/t1510-repo-setup.sh | 1 -
 1 file changed, 1 deletion(-)
Show changes to t/t1510-repo-setup.sh +0 −1
diff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh
index e6854b828..972bd9c78 100755
--- a/t/t1510-repo-setup.sh
+++ b/t/t1510-repo-setup.sh
@@ -238,7 +238,6 @@ test_expect_success '#0: nonbare repo, no explicit configuration' '
 '
 
 test_expect_success '#1: GIT_WORK_TREE without explicit GIT_DIR is accepted' '
-	mkdir -p wt &&
 	try_repo 1 "$here" unset unset "" unset \
 		"$here/1/.git" "$here" "$here" 1/ \
 		"$here/1/.git" "$here" "$here" 1/sub/ 2>message &&
-- 
2.16.2
Junio C Hamano· Apr 16, 2018, 01:18 UTC · re: qingyunha@foxmail.com · lore

Re: [PATCH] t1510-repo-setup.sh: rm useless mkdir

qingyunha@foxmail.com writes:
Show 19 quoted lines
> From: Tao Qingyun <845767657@qq.com>
>
> Signed-off-by: Tao Qingyun <845767657@qq.com>
> ---
>  t/t1510-repo-setup.sh | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh
> index e6854b828..972bd9c78 100755
> --- a/t/t1510-repo-setup.sh
> +++ b/t/t1510-repo-setup.sh
> @@ -238,7 +238,6 @@ test_expect_success '#0: nonbare repo, no explicit configuration' '
>  '
>  
>  test_expect_success '#1: GIT_WORK_TREE without explicit GIT_DIR is accepted' '
> -	mkdir -p wt &&
>  	try_repo 1 "$here" unset unset "" unset \
>  		"$here/1/.git" "$here" "$here" 1/ \
>  		"$here/1/.git" "$here" "$here" 1/sub/ 2>message &&
Interesting.  

This was added by 4868b2ea ("setup: officially support --work-tree without --git-dir", 2011-01-19), together with others like 9/wt that do get used. I am not sure if the old codebase needed this directory created and over time we lost the need for it, or what.

← back to recent threads