# [PATCH] t1510-repo-setup.sh: rm useless mkdir 2 messages from 2018-04-15 to 2018-04-16. Participants: qingyunha@foxmail.com, Junio C Hamano. Thread: https://gitlist.dev/t/48290 ## qingyunha@foxmail.com, 2018-04-15 02:45 Subject: [PATCH] t1510-repo-setup.sh: rm useless mkdir Message-ID: <20180415024504.2397-1-qingyunha@foxmail.com> URL: https://gitlist.dev/e/20180415024504.2397-1-qingyunha%40foxmail.com ``` From: Tao Qingyun <845767657@qq.com> Signed-off-by: Tao Qingyun <845767657@qq.com> --- t/t1510-repo-setup.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh index e6854b828..972bd9c78 100755 --- a/t/t1510-repo-setup.sh +++ b/t/t1510-repo-setup.sh @@ -238,7 +238,6 @@ test_expect_success '#0: nonbare repo, no explicit configuration' ' ' test_expect_success '#1: GIT_WORK_TREE without explicit GIT_DIR is accepted' ' - mkdir -p wt && try_repo 1 "$here" unset unset "" unset \ "$here/1/.git" "$here" "$here" 1/ \ "$here/1/.git" "$here" "$here" 1/sub/ 2>message && -- 2.16.2 ``` ## Junio C Hamano, 2018-04-16 01:18 Subject: Re: [PATCH] t1510-repo-setup.sh: rm useless mkdir Message-ID: URL: https://gitlist.dev/e/xmqqfu3wymmo.fsf%40gitster-ct.c.googlers.com In-Reply-To: <20180415024504.2397-1-qingyunha@foxmail.com> ``` qingyunha@foxmail.com writes: > From: Tao Qingyun <845767657@qq.com> > > Signed-off-by: Tao Qingyun <845767657@qq.com> > --- > t/t1510-repo-setup.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/t/t1510-repo-setup.sh b/t/t1510-repo-setup.sh > index e6854b828..972bd9c78 100755 > --- a/t/t1510-repo-setup.sh > +++ b/t/t1510-repo-setup.sh > @@ -238,7 +238,6 @@ test_expect_success '#0: nonbare repo, no explicit configuration' ' > ' > > test_expect_success '#1: GIT_WORK_TREE without explicit GIT_DIR is accepted' ' > - mkdir -p wt && > try_repo 1 "$here" unset unset "" unset \ > "$here/1/.git" "$here" "$here" 1/ \ > "$here/1/.git" "$here" "$here" 1/sub/ 2>message && Interesting. This was added by 4868b2ea ("setup: officially support --work-tree without --git-dir", 2011-01-19), together with others like 9/wt that do get used. I am not sure if the old codebase needed this directory created and over time we lost the need for it, or what. ```