[PATCH] Change permissions on git-completion.bash

Stephon Harris· Apr 4, 2018, 20:05 UTC · lore

Updating  git-completion.bash to include instructions to change the permissions on the file when sourcing it in your .bashrc or .zshrc file.
---
 contrib/completion/git-completion.bash | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Show changes to contrib/completion/git-completion.bash +3 −3

diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index b09c8a23626b4..fcd76cf169559 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -18,9 +18,10 @@
 # To use these routines:
 #
 #    1) Copy this file to somewhere (e.g. ~/.git-completion.bash).
-#    2) Add the following line to your .bashrc/.zshrc:
+#    2) Change the permissions of the file to be executable (e.g. chmod u+x  ~/.git-completion.bash)
+#    3) Add the following line to your .bashrc/.zshrc:
 #        source ~/.git-completion.bash
-#    3) Consider changing your PS1 to also show the current branch,
+#    4) Consider changing your PS1 to also show the current branch,
 #       see git-prompt.sh for details.
 #
 # If you use complex aliases of form '!f() { ... }; f', you can use the null

--
https://github.com/git/git/pull/480

Ævar Arnfjörð Bjarmason· Apr 4, 2018, 20:21 UTC · re: Stephon Harris · lore

Re: [PATCH] Change permissions on git-completion.bash

On Wed, Apr 04 2018, Stephon Harris wrote:

> Updating git-completion.bash to include instructions to change the
> permissions on the file when sourcing it in your .bashrc or .zshrc
> file.

But why is this needed? Files sourced by shells don't need to be executable, and quoting the bash manual "The file searched for in PATH need not be executable.".

What breaks for you / doesn't work because it doesn't have the +x bit?

patchChange permissions on git-completion.bash