{"thread":{"id":"48221","subject":"[PATCH] Change permissions on git-completion.bash","startedAt":"2018-04-04T20:05:43Z","lastAt":"2018-04-04T20:21:22Z","messageCount":2,"participants":["Stephon Harris","Ævar Arnfjörð Bjarmason"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"343813","messageId":"010201629243c44a-4a158009-aa68-4e05-ab54-f15a49ffb606-000000@eu-west-1.amazonses.com","threadId":"48221","inReplyTo":null,"subject":"[PATCH] Change permissions on git-completion.bash","fromName":"Stephon Harris","fromEmail":"theonestep4@gmail.com","sentAt":"2018-04-04T20:05:37Z","receivedAt":"2018-04-04T20:05:43Z","isPatch":true,"sender":{"key":"theonestep4@gmail.com","avatar":null},"body":"Updating  git-completion.bash to include instructions to change the permissions on the file when sourcing it in your .bashrc or .zshrc file.\n---\n contrib/completion/git-completion.bash | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash\nindex b09c8a23626b4..fcd76cf169559 100644\n--- a/contrib/completion/git-completion.bash\n+++ b/contrib/completion/git-completion.bash\n@@ -18,9 +18,10 @@\n # To use these routines:\n #\n #    1) Copy this file to somewhere (e.g. ~/.git-completion.bash).\n-#    2) Add the following line to your .bashrc/.zshrc:\n+#    2) Change the permissions of the file to be executable (e.g. chmod u+x  ~/.git-completion.bash)\n+#    3) Add the following line to your .bashrc/.zshrc:\n #        source ~/.git-completion.bash\n-#    3) Consider changing your PS1 to also show the current branch,\n+#    4) Consider changing your PS1 to also show the current branch,\n #       see git-prompt.sh for details.\n #\n # If you use complex aliases of form '!f() { ... }; f', you can use the null\n\n--\nhttps://github.com/git/git/pull/480\n"},{"id":"343814","messageId":"877epm205i.fsf@evledraar.gmail.com","threadId":"48221","inReplyTo":"010201629243c44a-4a158009-aa68-4e05-ab54-f15a49ffb606-000000@eu-west-1.amazonses.com","subject":"Re: [PATCH] Change permissions on git-completion.bash","fromName":"Ævar Arnfjörð Bjarmason","fromEmail":"avarab@gmail.com","sentAt":"2018-04-04T20:21:13Z","receivedAt":"2018-04-04T20:21:22Z","isPatch":true,"sender":{"key":"avarab@gmail.com","avatar":"https://avatars.githubusercontent.com/u/45301?v=4"},"body":"\nOn Wed, Apr 04 2018, Stephon Harris wrote:\n\n> Updating git-completion.bash to include instructions to change the\n> permissions on the file when sourcing it in your .bashrc or .zshrc\n> file.\n\nBut why is this needed? Files sourced by shells don't need to be\nexecutable, and quoting the bash manual \"The file searched for in PATH\nneed not be executable.\".\n\nWhat breaks for you / doesn't work because it doesn't have the +x bit?\n"}]}