threads / discuss / 47951

git-gui: CTRL/CMD + numpad ENTER does not invoke same command as "regular" ENTER

Subject: git-gui: CTRL/CMD + numpad ENTER does not invoke same command as "regular" ENTER

## tl;dr

5 messages between Mar 1, 2018 and Mar 2, 2018.

replies: 4people: 2as markdown or json

Birger Skogeng Pedersen· Mar 1, 2018, 14:25 UTC · lore

In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However, using the numpad ENTER does not invoke the same command.

I propose that both numpad ENTER and "regular" ENTER should invoke the same command.

Birger Skogeng Pedersen· Mar 1, 2018, 14:39 UTC · re: Birger Skogeng Pedersen · lore

[PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit

---
 git-gui/git-gui.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 91c00e648..6de74ce63 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -3867,6 +3867,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
 bind .   <$M1B-Key-plus> {show_more_context;break}
 bind .   <$M1B-Key-KP_Add> {show_more_context;break}
 bind .   <$M1B-Key-Return> do_commit
+bind .   <$M1B-Key-KP_Enter> do_commit
 foreach i [list $ui_index $ui_workdir] {
 	bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
 	bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }

-- 
2.16.2.268.g7f9c27f2f.dirty

Eric Sunshine· Mar 1, 2018, 18:31 UTC · re: Birger Skogeng Pedersen · lore

Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit

On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen <birgersp@gmail.com> wrote:

> ---

Please sign-off on your patch. See Documentation/SubmittingPatches.

Also, it would be helpful to write at least a short commit message justifying the change. The reason you gave in your lead-in email[1] might be sufficient:

    In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,
    using the numpad ENTER does not invoke the same command.

(assuming people don't argue that numpad ENTER should be saved for some other function).

Thanks.

[1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com/

Show 12 quoted lines

> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> index 91c00e648..6de74ce63 100755
> --- a/git-gui/git-gui.sh
> +++ b/git-gui/git-gui.sh
> @@ -3867,6 +3867,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
>  bind .   <$M1B-Key-plus> {show_more_context;break}
>  bind .   <$M1B-Key-KP_Add> {show_more_context;break}
>  bind .   <$M1B-Key-Return> do_commit
> +bind .   <$M1B-Key-KP_Enter> do_commit
>  foreach i [list $ui_index $ui_workdir] {
>         bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
>         bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }

Birger Skogeng Pedersen· Mar 2, 2018, 09:56 UTC · re: Eric Sunshine · lore

Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit

Sorry about that. Version 2 coming right up.

On Thu, Mar 1, 2018 at 7:31 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 32 quoted lines

> On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen
> <birgersp@gmail.com> wrote:
>> ---
>
> Please sign-off on your patch. See Documentation/SubmittingPatches.
>
> Also, it would be helpful to write at least a short commit message
> justifying the change. The reason you gave in your lead-in email[1]
> might be sufficient:
>
>     In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,
>     using the numpad ENTER does not invoke the same command.
>
> (assuming people don't argue that numpad ENTER should be saved for
> some other function).
>
> Thanks.
>
> [1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com/
>
>> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
>> index 91c00e648..6de74ce63 100755
>> --- a/git-gui/git-gui.sh
>> +++ b/git-gui/git-gui.sh
>> @@ -3867,6 +3867,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
>>  bind .   <$M1B-Key-plus> {show_more_context;break}
>>  bind .   <$M1B-Key-KP_Add> {show_more_context;break}
>>  bind .   <$M1B-Key-Return> do_commit
>> +bind .   <$M1B-Key-KP_Enter> do_commit
>>  foreach i [list $ui_index $ui_workdir] {
>>         bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
>>         bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }

Birger Skogeng Pedersen· Mar 2, 2018, 10:01 UTC · re: Birger Skogeng Pedersen · lore

[PATCH v2] git-gui: bind CTRL/CMD+numpad ENTER to do_commit

CTRL/CMD+ENTER is bound to do_commit, but this did not apply for the (numpad ENTER) key. To enable CTRL/CMD+ENTER and CTRL/CMD+(numpad ENTER) to yield the same behaviour, CTRL/CMD+(numpad enter) has also been bound to do_commit.

Signed-off-by: Birger Skogeng Pedersen <birgersp@gmail.com>
---
 git-gui/git-gui.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 91c00e648..6de74ce63 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -3867,6 +3867,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}
 bind .   <$M1B-Key-plus> {show_more_context;break}
 bind .   <$M1B-Key-KP_Add> {show_more_context;break}
 bind .   <$M1B-Key-Return> do_commit
+bind .   <$M1B-Key-KP_Enter> do_commit
 foreach i [list $ui_index $ui_workdir] {
 	bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }
 	bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }

-- 
2.16.2.270.gdc6133cf5