{"thread":{"id":"47951","subject":"git-gui: CTRL/CMD + numpad ENTER does not invoke same command as \"regular\" ENTER","startedAt":"2018-03-01T14:25:30Z","lastAt":"2018-03-02T10:02:12Z","messageCount":5,"participants":["Birger Skogeng Pedersen","Eric Sunshine"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"340725","messageId":"CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com","threadId":"47951","inReplyTo":null,"subject":"git-gui: CTRL/CMD + numpad ENTER does not invoke same command as \"regular\" ENTER","fromName":"Birger Skogeng Pedersen","fromEmail":"birgersp@gmail.com","sentAt":"2018-03-01T14:25:22Z","receivedAt":"2018-03-01T14:25:30Z","isPatch":false,"sender":{"key":"birgersp@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5260237?v=4"},"body":"In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,\nusing the numpad ENTER does not invoke the same command.\n\nI propose that both numpad ENTER and \"regular\" ENTER should invoke the\nsame command.\n"},{"id":"340727","messageId":"20180301143904.28652-1-birgersp@gmail.com","threadId":"47951","inReplyTo":"CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com","subject":"[PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit","fromName":"Birger Skogeng Pedersen","fromEmail":"birgersp@gmail.com","sentAt":"2018-03-01T14:39:04Z","receivedAt":"2018-03-01T14:39:14Z","isPatch":true,"sender":{"key":"birgersp@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5260237?v=4"},"body":"---\n git-gui/git-gui.sh | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 91c00e648..6de74ce63 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -3867,6 +3867,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}\n bind .   <$M1B-Key-plus> {show_more_context;break}\n bind .   <$M1B-Key-KP_Add> {show_more_context;break}\n bind .   <$M1B-Key-Return> do_commit\n+bind .   <$M1B-Key-KP_Enter> do_commit\n foreach i [list $ui_index $ui_workdir] {\n \tbind $i <Button-1>       { toggle_or_diff click %W %x %y; break }\n \tbind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }\n-- \n2.16.2.268.g7f9c27f2f.dirty\n\n"},{"id":"340744","messageId":"CAPig+cRt+u4yEnFLM3kUB_J54Xvt6V9ceb6rwqfHC3kb=fttGg@mail.gmail.com","threadId":"47951","inReplyTo":"20180301143904.28652-1-birgersp@gmail.com","subject":"Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2018-03-01T18:31:06Z","receivedAt":"2018-03-01T18:31:14Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen\n<birgersp@gmail.com> wrote:\n> ---\n\nPlease sign-off on your patch. See Documentation/SubmittingPatches.\n\nAlso, it would be helpful to write at least a short commit message\njustifying the change. The reason you gave in your lead-in email[1]\nmight be sufficient:\n\n    In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,\n    using the numpad ENTER does not invoke the same command.\n\n(assuming people don't argue that numpad ENTER should be saved for\nsome other function).\n\nThanks.\n\n[1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com/\n\n> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\n> index 91c00e648..6de74ce63 100755\n> --- a/git-gui/git-gui.sh\n> +++ b/git-gui/git-gui.sh\n> @@ -3867,6 +3867,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}\n>  bind .   <$M1B-Key-plus> {show_more_context;break}\n>  bind .   <$M1B-Key-KP_Add> {show_more_context;break}\n>  bind .   <$M1B-Key-Return> do_commit\n> +bind .   <$M1B-Key-KP_Enter> do_commit\n>  foreach i [list $ui_index $ui_workdir] {\n>         bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }\n>         bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }\n"},{"id":"340785","messageId":"CAGr--=JqXhwEtOrs0K3cscVa=LV75ejz=TYKtV7mgrd_96Jk6w@mail.gmail.com","threadId":"47951","inReplyTo":"CAPig+cRt+u4yEnFLM3kUB_J54Xvt6V9ceb6rwqfHC3kb=fttGg@mail.gmail.com","subject":"Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit","fromName":"Birger Skogeng Pedersen","fromEmail":"birgersp@gmail.com","sentAt":"2018-03-02T09:56:41Z","receivedAt":"2018-03-02T09:56:54Z","isPatch":true,"sender":{"key":"birgersp@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5260237?v=4"},"body":"Sorry about that. Version 2 coming right up.\n\nOn Thu, Mar 1, 2018 at 7:31 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:\n> On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen\n> <birgersp@gmail.com> wrote:\n>> ---\n>\n> Please sign-off on your patch. See Documentation/SubmittingPatches.\n>\n> Also, it would be helpful to write at least a short commit message\n> justifying the change. The reason you gave in your lead-in email[1]\n> might be sufficient:\n>\n>     In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,\n>     using the numpad ENTER does not invoke the same command.\n>\n> (assuming people don't argue that numpad ENTER should be saved for\n> some other function).\n>\n> Thanks.\n>\n> [1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com/\n>\n>> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\n>> index 91c00e648..6de74ce63 100755\n>> --- a/git-gui/git-gui.sh\n>> +++ b/git-gui/git-gui.sh\n>> @@ -3867,6 +3867,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}\n>>  bind .   <$M1B-Key-plus> {show_more_context;break}\n>>  bind .   <$M1B-Key-KP_Add> {show_more_context;break}\n>>  bind .   <$M1B-Key-Return> do_commit\n>> +bind .   <$M1B-Key-KP_Enter> do_commit\n>>  foreach i [list $ui_index $ui_workdir] {\n>>         bind $i <Button-1>       { toggle_or_diff click %W %x %y; break }\n>>         bind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }\n"},{"id":"340786","messageId":"20180302100148.23899-1-birgersp@gmail.com","threadId":"47951","inReplyTo":"CAGr--=JqXhwEtOrs0K3cscVa=LV75ejz=TYKtV7mgrd_96Jk6w@mail.gmail.com","subject":"[PATCH v2] git-gui: bind CTRL/CMD+numpad ENTER to do_commit","fromName":"Birger Skogeng Pedersen","fromEmail":"birgersp@gmail.com","sentAt":"2018-03-02T10:01:48Z","receivedAt":"2018-03-02T10:02:12Z","isPatch":true,"sender":{"key":"birgersp@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5260237?v=4"},"body":"CTRL/CMD+ENTER is bound to do_commit, but this did not apply for the\n(numpad ENTER) key. To enable CTRL/CMD+ENTER and CTRL/CMD+(numpad ENTER)\nto yield the same behaviour, CTRL/CMD+(numpad enter) has also been bound\nto do_commit.\n\nSigned-off-by: Birger Skogeng Pedersen <birgersp@gmail.com>\n---\n git-gui/git-gui.sh | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh\nindex 91c00e648..6de74ce63 100755\n--- a/git-gui/git-gui.sh\n+++ b/git-gui/git-gui.sh\n@@ -3867,6 +3867,7 @@ bind .   <$M1B-Key-equal> {show_more_context;break}\n bind .   <$M1B-Key-plus> {show_more_context;break}\n bind .   <$M1B-Key-KP_Add> {show_more_context;break}\n bind .   <$M1B-Key-Return> do_commit\n+bind .   <$M1B-Key-KP_Enter> do_commit\n foreach i [list $ui_index $ui_workdir] {\n \tbind $i <Button-1>       { toggle_or_diff click %W %x %y; break }\n \tbind $i <$M1B-Button-1>  { add_one_to_selection %W %x %y; break }\n-- \n2.16.2.270.gdc6133cf5\n\n"}]}