threads / patch / 46778

patch, 2 partstest-lib: use more compact expression in PIPE prerequisite

Subject: [PATCH 1/2] test-lib: use more compact expression in PIPE prerequisite

## tl;dr

2 messages between Sep 17, 2017 and Sep 19, 2017. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Sep 17, 2017, 22:56 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
 t/test-lib.sh | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

Show changes to t/test-lib.sh +2 −8

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 32f9b2001..9b61f16f7 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -1067,14 +1067,8 @@ test_i18ngrep () {
 
 test_lazy_prereq PIPE '
 	# test whether the filesystem supports FIFOs
-	case $(uname -s) in
-	CYGWIN*|MINGW*)
-		false
-		;;
-	*)
-		rm -f testfifo && mkfifo testfifo
-		;;
-	esac
+	test_have_prereq !MINGW,!CYGWIN &&
+	rm -f testfifo && mkfifo testfifo
 '
 
 test_lazy_prereq SYMLINKS '

-- 
2.14.0

Jonathan Nieder· Sep 19, 2017, 02:50 UTC · re: Ramsay Jones · lore

Re: [PATCH 1/2] test-lib: use more compact expression in PIPE prerequisite

Ramsay Jones wrote:

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  t/test-lib.sh | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>