# [PATCH 1/2] test-lib: use more compact expression in PIPE prerequisite

2 messages from 2017-09-17 to 2017-09-19. Participants: Ramsay Jones, Jonathan Nieder.
Thread: https://gitlist.dev/t/46778

## Ramsay Jones, 2017-09-17 22:56

Subject: [PATCH 1/2] test-lib: use more compact expression in PIPE prerequisite
Message-ID: <308f3128-a96e-e7f0-e430-5eb10b08ec08@ramsayjones.plus.com>
URL: https://gitlist.dev/e/308f3128-a96e-e7f0-e430-5eb10b08ec08%40ramsayjones.plus.com

```

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
 t/test-lib.sh | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 32f9b2001..9b61f16f7 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -1067,14 +1067,8 @@ test_i18ngrep () {
 
 test_lazy_prereq PIPE '
 	# test whether the filesystem supports FIFOs
-	case $(uname -s) in
-	CYGWIN*|MINGW*)
-		false
-		;;
-	*)
-		rm -f testfifo && mkfifo testfifo
-		;;
-	esac
+	test_have_prereq !MINGW,!CYGWIN &&
+	rm -f testfifo && mkfifo testfifo
 '
 
 test_lazy_prereq SYMLINKS '
-- 
2.14.0

```

## Jonathan Nieder, 2017-09-19 02:50

Subject: Re: [PATCH 1/2] test-lib: use more compact expression in PIPE prerequisite
Message-ID: <20170919025017.GE175206@aiede.mtv.corp.google.com>
URL: https://gitlist.dev/e/20170919025017.GE175206%40aiede.mtv.corp.google.com
In-Reply-To: <308f3128-a96e-e7f0-e430-5eb10b08ec08@ramsayjones.plus.com>

```
Ramsay Jones wrote:

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>  t/test-lib.sh | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

```
