Fwd: bug: contrib/subtree: Commit message title should be in imperative mood

Bjørn Erik Pedersen· Aug 4, 2017, 21:05 UTC · lore

I.e. "Squash 'somedir' changes" and not "Squashed ..."

See

https://github.com/git/git/blob/master/contrib/subtree/git-subtree.sh#L463

Junio C Hamano· Aug 4, 2017, 21:21 UTC · re: Bjørn Erik Pedersen · lore

Re: Fwd: bug: contrib/subtree: Commit message title should be in imperative mood

Bjørn Erik Pedersen  <bjorn.erik.pedersen@gmail.com> writes:

Show 5 quoted lines

> I.e. "Squash 'somedir' changes" and not "Squashed ..."
>
> See
>
> https://github.com/git/git/blob/master/contrib/subtree/git-subtree.sh#L463

I do not think this is necessarily a good change.

"git subtree" (in contrib/) is not a tool limited to be used on projects that follow the same convention as the Git project itself.

Bjørn Erik Pedersen· Aug 4, 2017, 22:02 UTC · re: Junio C Hamano · lore

Re: Fwd: bug: contrib/subtree: Commit message title should be in imperative mood

I would argue that:

1. If used on the "Git project itself" (as in my case), the commit
message now cannot be used unedited because it is a conflict with the
project's guidelines, and also conflicts with the format of "all" (or
most) the other Git (and GitHub) commit titles.
2. If not "used on the Git project itself" (I assume it will always be
used on A Git project), changing the commit title to be in line with
the rest would not hurt anyone.

Bjørn Erik

2017-08-04 23:21 GMT+02:00 Junio C Hamano <gitster@pobox.com>:

Show 12 quoted lines

> Bjørn Erik Pedersen  <bjorn.erik.pedersen@gmail.com> writes:
>
>> I.e. "Squash 'somedir' changes" and not "Squashed ..."
>>
>> See
>>
>> https://github.com/git/git/blob/master/contrib/subtree/git-subtree.sh#L463
>
> I do not think this is necessarily a good change.
>
> "git subtree" (in contrib/) is not a tool limited to be used on
> projects that follow the same convention as the Git project itself.