{"thread":{"id":"46514","subject":"Fwd: bug: contrib/subtree: Commit message title should be in imperative mood","startedAt":"2017-08-04T21:05:29Z","lastAt":"2017-08-04T22:02:47Z","messageCount":3,"participants":["Bjørn Erik Pedersen","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"325626","messageId":"CAAM6cWenBUL6rNva+KmwnPhUwzGZeFs53=N8yOkyyTXOmXC2jw@mail.gmail.com","threadId":"46514","inReplyTo":"CAAM6cWfYfpX+8iK+SH=ukPutB18UAafXOZ3fuKQBiQ-4arp-8Q@mail.gmail.com","subject":"Fwd: bug: contrib/subtree: Commit message title should be in imperative mood","fromName":"Bjørn Erik Pedersen","fromEmail":"bjorn.erik.pedersen@gmail.com","sentAt":"2017-08-04T21:05:23Z","receivedAt":"2017-08-04T21:05:29Z","isPatch":false,"sender":{"key":"bjorn.erik.pedersen@gmail.com","avatar":null},"body":"I.e. \"Squash 'somedir' changes\" and not \"Squashed ...\"\n\nSee\n\nhttps://github.com/git/git/blob/master/contrib/subtree/git-subtree.sh#L463\n"},{"id":"325628","messageId":"xmqqy3qzrpvl.fsf@gitster.mtv.corp.google.com","threadId":"46514","inReplyTo":"CAAM6cWenBUL6rNva+KmwnPhUwzGZeFs53=N8yOkyyTXOmXC2jw@mail.gmail.com","subject":"Re: Fwd: bug: contrib/subtree: Commit message title should be in imperative mood","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-08-04T21:21:02Z","receivedAt":"2017-08-04T21:21:10Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Bjørn Erik Pedersen  <bjorn.erik.pedersen@gmail.com> writes:\n\n> I.e. \"Squash 'somedir' changes\" and not \"Squashed ...\"\n>\n> See\n>\n> https://github.com/git/git/blob/master/contrib/subtree/git-subtree.sh#L463\n\nI do not think this is necessarily a good change.\n\n\"git subtree\" (in contrib/) is not a tool limited to be used on\nprojects that follow the same convention as the Git project itself.\n"},{"id":"325633","messageId":"CAAM6cWety96B7yAxjsD+s=z1GXOwgdykT=D2W9wJrD=9Ph26eA@mail.gmail.com","threadId":"46514","inReplyTo":"xmqqy3qzrpvl.fsf@gitster.mtv.corp.google.com","subject":"Re: Fwd: bug: contrib/subtree: Commit message title should be in imperative mood","fromName":"Bjørn Erik Pedersen","fromEmail":"bjorn.erik.pedersen@gmail.com","sentAt":"2017-08-04T22:02:42Z","receivedAt":"2017-08-04T22:02:47Z","isPatch":false,"sender":{"key":"bjorn.erik.pedersen@gmail.com","avatar":null},"body":"I would argue that:\n\n1. If used on the \"Git project itself\" (as in my case), the commit\nmessage now cannot be used unedited because it is a conflict with the\nproject's guidelines, and also conflicts with the format of \"all\" (or\nmost) the other Git (and GitHub) commit titles.\n2. If not \"used on the Git project itself\" (I assume it will always be\nused on A Git project), changing the commit title to be in line with\nthe rest would not hurt anyone.\n\nBjørn Erik\n\n2017-08-04 23:21 GMT+02:00 Junio C Hamano <gitster@pobox.com>:\n> Bjørn Erik Pedersen  <bjorn.erik.pedersen@gmail.com> writes:\n>\n>> I.e. \"Squash 'somedir' changes\" and not \"Squashed ...\"\n>>\n>> See\n>>\n>> https://github.com/git/git/blob/master/contrib/subtree/git-subtree.sh#L463\n>\n> I do not think this is necessarily a good change.\n>\n> \"git subtree\" (in contrib/) is not a tool limited to be used on\n> projects that follow the same convention as the Git project itself.\n"}]}