threads / patch / 46438

patchconfig.mak.uname: set FREAD_READS_DIRECTORIES for cygwin

Subject: [PATCH] config.mak.uname: set FREAD_READS_DIRECTORIES for cygwin

## tl;dr

2 messages between Jul 21, 2017 and Jul 21, 2017. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Ramsay Jones· Jul 21, 2017, 18:43 UTC · lore

Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Junio,

My 'make test' run for the v2.14.0-rc0 on cygwin turned up a new test failure (over and above the v2.13.0 failures), namely t1308.23. Running the test in the debugger showed that cygwin was fopen-ing the 'a-directory' without problem.

On one occasion, while in the debugger, I did see fopen return NULL while trying to open a directory. So, I created a test program which showed reliably that fopen succeeds on a directory. (So, maybe I was just seeing things! :-D ).

t1308 was reliably failing before this patch, afterwards it reliably passes, so ...

[I have a full test run going at the moment, but it won't finish for about 3 hours.]

ATB, Ramsay Jones

 config.mak.uname | 1 +
 1 file changed, 1 insertion(+)

Show changes to config.mak.uname +1 −0

diff --git a/config.mak.uname b/config.mak.uname
index 551e465a7..6604b130f 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -185,6 +185,7 @@ ifeq ($(uname_O),Cygwin)
 	SPARSE_FLAGS = -isystem /usr/include/w32api -Wno-one-bit-signed-bitfield
 	OBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo
 	COMPAT_OBJS += compat/cygwin.o
+	FREAD_READS_DIRECTORIES = UnfortunatelyYes
 endif
 ifeq ($(uname_S),FreeBSD)
 	NEEDS_LIBICONV = YesPlease

-- 
2.13.0

Junio C Hamano· Jul 21, 2017, 19:28 UTC · re: Ramsay Jones · lore

Re: [PATCH] config.mak.uname: set FREAD_READS_DIRECTORIES for cygwin

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

Show 23 quoted lines

> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
> ---
>
> Hi Junio,
>
> My 'make test' run for the v2.14.0-rc0 on cygwin turned up a new
> test failure (over and above the v2.13.0 failures), namely t1308.23.
> Running the test in the debugger showed that cygwin was fopen-ing
> the 'a-directory' without problem.
>
> On one occasion, while in the debugger, I did see fopen return NULL
> while trying to open a directory. So, I created a test program which
> showed reliably that fopen succeeds on a directory. (So, maybe I was
> just seeing things! :-D ).
>
> t1308 was reliably failing before this patch, afterwards it reliably
> passes, so ...
>
> [I have a full test run going at the moment, but it won't finish for
> about 3 hours.]
>
> ATB,
> Ramsay Jones

Thanks.  Let's apply it for -rc1.

Show 16 quoted lines

>
>  config.mak.uname | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/config.mak.uname b/config.mak.uname
> index 551e465a7..6604b130f 100644
> --- a/config.mak.uname
> +++ b/config.mak.uname
> @@ -185,6 +185,7 @@ ifeq ($(uname_O),Cygwin)
>  	SPARSE_FLAGS = -isystem /usr/include/w32api -Wno-one-bit-signed-bitfield
>  	OBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo
>  	COMPAT_OBJS += compat/cygwin.o
> +	FREAD_READS_DIRECTORIES = UnfortunatelyYes
>  endif
>  ifeq ($(uname_S),FreeBSD)
>  	NEEDS_LIBICONV = YesPlease