{"thread":{"id":"46438","subject":"[PATCH] config.mak.uname: set FREAD_READS_DIRECTORIES for cygwin","startedAt":"2017-07-21T18:43:24Z","lastAt":"2017-07-21T19:28:42Z","messageCount":2,"participants":["Ramsay Jones","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"324881","messageId":"506cb9f2-cf59-2df6-2d4c-30c82dfbf85b@ramsayjones.plus.com","threadId":"46438","inReplyTo":null,"subject":"[PATCH] config.mak.uname: set FREAD_READS_DIRECTORIES for cygwin","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2017-07-21T18:43:17Z","receivedAt":"2017-07-21T18:43:24Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi Junio,\n\nMy 'make test' run for the v2.14.0-rc0 on cygwin turned up a new\ntest failure (over and above the v2.13.0 failures), namely t1308.23.\nRunning the test in the debugger showed that cygwin was fopen-ing\nthe 'a-directory' without problem.\n\nOn one occasion, while in the debugger, I did see fopen return NULL\nwhile trying to open a directory. So, I created a test program which\nshowed reliably that fopen succeeds on a directory. (So, maybe I was\njust seeing things! :-D ).\n\nt1308 was reliably failing before this patch, afterwards it reliably\npasses, so ...\n\n[I have a full test run going at the moment, but it won't finish for\nabout 3 hours.]\n\nATB,\nRamsay Jones\n\n config.mak.uname | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/config.mak.uname b/config.mak.uname\nindex 551e465a7..6604b130f 100644\n--- a/config.mak.uname\n+++ b/config.mak.uname\n@@ -185,6 +185,7 @@ ifeq ($(uname_O),Cygwin)\n \tSPARSE_FLAGS = -isystem /usr/include/w32api -Wno-one-bit-signed-bitfield\n \tOBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo\n \tCOMPAT_OBJS += compat/cygwin.o\n+\tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n endif\n ifeq ($(uname_S),FreeBSD)\n \tNEEDS_LIBICONV = YesPlease\n-- \n2.13.0\n"},{"id":"324884","messageId":"xmqq4lu5h9nl.fsf@gitster.mtv.corp.google.com","threadId":"46438","inReplyTo":"506cb9f2-cf59-2df6-2d4c-30c82dfbf85b@ramsayjones.plus.com","subject":"Re: [PATCH] config.mak.uname: set FREAD_READS_DIRECTORIES for cygwin","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-07-21T19:28:30Z","receivedAt":"2017-07-21T19:28:42Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Ramsay Jones <ramsay@ramsayjones.plus.com> writes:\n\n> Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n> ---\n>\n> Hi Junio,\n>\n> My 'make test' run for the v2.14.0-rc0 on cygwin turned up a new\n> test failure (over and above the v2.13.0 failures), namely t1308.23.\n> Running the test in the debugger showed that cygwin was fopen-ing\n> the 'a-directory' without problem.\n>\n> On one occasion, while in the debugger, I did see fopen return NULL\n> while trying to open a directory. So, I created a test program which\n> showed reliably that fopen succeeds on a directory. (So, maybe I was\n> just seeing things! :-D ).\n>\n> t1308 was reliably failing before this patch, afterwards it reliably\n> passes, so ...\n>\n> [I have a full test run going at the moment, but it won't finish for\n> about 3 hours.]\n>\n> ATB,\n> Ramsay Jones\n\nThanks.  Let's apply it for -rc1.\n\n>\n>  config.mak.uname | 1 +\n>  1 file changed, 1 insertion(+)\n>\n> diff --git a/config.mak.uname b/config.mak.uname\n> index 551e465a7..6604b130f 100644\n> --- a/config.mak.uname\n> +++ b/config.mak.uname\n> @@ -185,6 +185,7 @@ ifeq ($(uname_O),Cygwin)\n>  \tSPARSE_FLAGS = -isystem /usr/include/w32api -Wno-one-bit-signed-bitfield\n>  \tOBJECT_CREATION_USES_RENAMES = UnfortunatelyNeedsTo\n>  \tCOMPAT_OBJS += compat/cygwin.o\n> +\tFREAD_READS_DIRECTORIES = UnfortunatelyYes\n>  endif\n>  ifeq ($(uname_S),FreeBSD)\n>  \tNEEDS_LIBICONV = YesPlease\n"}]}