threads / discuss / 463

PATCH: diff-cache.c:51: `return' with a value, in function returning void

Subject: PATCH: diff-cache.c:51: `return' with a value, in function returning void

## tl;dr

3 messages between May 3, 2005 and May 3, 2005.

replies: 2people: 2as markdown or json

Alex Riesen· May 3, 2005, 19:56 UTC · lore

gcc -g -O2 -Wall '-DSHA1_HEADER=<openssl/sha.h>' -o git-diff-cache diff-cache.c libgit.a -lz -lssl diff-cache.c: In function `show_new_file': diff-cache.c:51: warning: `return' with a value, in function returning void

--- cogito/diff-cache.c 2005-05-03 21:50:42.000000000 +0200 +++ cogito/diff-cache.c 2005-05-03 21:52:00.000000000 +0200

@@ -48,7 +48,6 @@ static void show_new_file(struct cache_e
 		return;
 
 	show_file("+", new, sha1, mode);
-	return 0;
 }
 
 static int show_modified(struct cache_entry *old, struct cache_entry *new)

Junio C Hamano· May 3, 2005, 21:33 UTC · re: Alex Riesen · lore

Re: PATCH: diff-cache.c:51: `return' with a value, in function returning void

>>>>> "AR" == Alex Riesen <fork0@users.sourceforge.net> writes:

AR> gcc -g -O2 -Wall '-DSHA1_HEADER=<openssl/sha.h>' -o git-diff-cache diff-cache.c libgit.a -lz -lssl AR> diff-cache.c: In function `show_new_file': AR> diff-cache.c:51: warning: `return' with a value, in function returning void

This one was fixed in the Linus tree long time ago.

Alex Riesen· May 3, 2005, 21:44 UTC · re: Junio C Hamano · lore

Re: PATCH: diff-cache.c:51: `return' with a value, in function returning void

Junio C Hamano, Tue, May 03, 2005 23:33:22 +0200:

Show 8 quoted lines

> >>>>> "AR" == Alex Riesen <fork0@users.sourceforge.net> writes:
> 
> AR> gcc -g -O2 -Wall  '-DSHA1_HEADER=<openssl/sha.h>' -o git-diff-cache diff-cache.c libgit.a -lz -lssl
> AR> diff-cache.c: In function `show_new_file':
> AR> diff-cache.c:51: warning: `return' with a value, in function returning void
> 
> This one was fixed in the Linus tree long time ago.
>

Oh, sorry: it was cogito today.