{"thread":{"id":"463","subject":"PATCH: diff-cache.c:51: `return' with a value, in function returning void","startedAt":"2005-05-03T19:56:01Z","lastAt":"2005-05-03T21:44:34Z","messageCount":3,"participants":["Alex Riesen","Junio C Hamano"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"2513","messageId":"20050503195601.GA4165@steel.home","threadId":"463","inReplyTo":null,"subject":"PATCH: diff-cache.c:51: `return' with a value, in function returning void","fromName":"Alex Riesen","fromEmail":"fork0@users.sourceforge.net","sentAt":"2005-05-03T19:56:01Z","receivedAt":"2005-05-03T19:56:01Z","isPatch":false,"sender":{"key":"fork0@users.sourceforge.net","avatar":null},"body":"gcc -g -O2 -Wall  '-DSHA1_HEADER=<openssl/sha.h>' -o git-diff-cache diff-cache.c libgit.a -lz -lssl\ndiff-cache.c: In function `show_new_file':\ndiff-cache.c:51: warning: `return' with a value, in function returning void\n\n\n--- cogito/diff-cache.c\t2005-05-03 21:50:42.000000000 +0200\n+++ cogito/diff-cache.c\t2005-05-03 21:52:00.000000000 +0200\n@@ -48,7 +48,6 @@ static void show_new_file(struct cache_e\n \t\treturn;\n \n \tshow_file(\"+\", new, sha1, mode);\n-\treturn 0;\n }\n \n static int show_modified(struct cache_entry *old, struct cache_entry *new)\n\n"},{"id":"2529","messageId":"7vmzrct2ot.fsf@assigned-by-dhcp.cox.net","threadId":"463","inReplyTo":"20050503195601.GA4165@steel.home","subject":"Re: PATCH: diff-cache.c:51: `return' with a value, in function returning void","fromName":"Junio C Hamano","fromEmail":"junkio@cox.net","sentAt":"2005-05-03T21:33:22Z","receivedAt":"2005-05-03T21:33:22Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":">>>>> \"AR\" == Alex Riesen <fork0@users.sourceforge.net> writes:\n\nAR> gcc -g -O2 -Wall  '-DSHA1_HEADER=<openssl/sha.h>' -o git-diff-cache diff-cache.c libgit.a -lz -lssl\nAR> diff-cache.c: In function `show_new_file':\nAR> diff-cache.c:51: warning: `return' with a value, in function returning void\n\nThis one was fixed in the Linus tree long time ago.\n\n"},{"id":"2532","messageId":"20050503214434.GA31958@steel.home","threadId":"463","inReplyTo":"7vmzrct2ot.fsf@assigned-by-dhcp.cox.net","subject":"Re: PATCH: diff-cache.c:51: `return' with a value, in function returning void","fromName":"Alex Riesen","fromEmail":"fork0@users.sourceforge.net","sentAt":"2005-05-03T21:44:34Z","receivedAt":"2005-05-03T21:44:34Z","isPatch":false,"sender":{"key":"fork0@users.sourceforge.net","avatar":null},"body":"Junio C Hamano, Tue, May 03, 2005 23:33:22 +0200:\n> >>>>> \"AR\" == Alex Riesen <fork0@users.sourceforge.net> writes:\n> \n> AR> gcc -g -O2 -Wall  '-DSHA1_HEADER=<openssl/sha.h>' -o git-diff-cache diff-cache.c libgit.a -lz -lssl\n> AR> diff-cache.c: In function `show_new_file':\n> AR> diff-cache.c:51: warning: `return' with a value, in function returning void\n> \n> This one was fixed in the Linus tree long time ago.\n> \n\nOh, sorry: it was cogito today.\n\n"}]}