threads / patch / 46274

patchls-remote: remove "-h" from help text

Subject: [PATCH 1/1] ls-remote: remove "-h" from help text

## tl;dr

4 messages between Jun 27, 2017 and Jun 28, 2017. Diffs are folded; open one to read it.

replies: 3people: 2as markdown or json

Silvio Fricke· Jun 27, 2017, 20:34 UTC · lore

[PATCH 0/1] fix ls-remote help message

Hi,

a small patch about a wrong help text. Please include when okay.

Best Regards, Silvio

Silvio Fricke (1):
  ls-remote: remove "-h" from help text

 builtin/ls-remote.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.13.2

Silvio Fricke· Jun 27, 2017, 20:34 UTC · re: Silvio Fricke · lore

This regression was fixed in 91a640ffb6d9 ("ls-remote: a lone "-h" is asking for help") and the wrong help text was introduced in ba5f28bf79ea ("ls-remote: use parse-options api"). This patch removes the "-h" on the help text.

Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
---
 builtin/ls-remote.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to builtin/ls-remote.c +1 −1

diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c
index b2d7d5ce6..cd54f7e98 100644
--- a/builtin/ls-remote.c
+++ b/builtin/ls-remote.c
@@ -56,7 +56,7 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
 			   N_("path of git-upload-pack on the remote host"),
 			   PARSE_OPT_HIDDEN },
 		OPT_BIT('t', "tags", &flags, N_("limit to tags"), REF_TAGS),
-		OPT_BIT('h', "heads", &flags, N_("limit to heads"), REF_HEADS),
+		OPT_BIT(0, "heads", &flags, N_("limit to heads"), REF_HEADS),
 		OPT_BIT(0, "refs", &flags, N_("do not show peeled tags"), REF_NORMAL),
 		OPT_BOOL(0, "get-url", &get_url,
 			 N_("take url.<base>.insteadOf into account")),

-- 
2.13.2

Jonathan Nieder· Jun 27, 2017, 21:09 UTC · re: Silvio Fricke · lore

Re: [PATCH 1/1] ls-remote: remove "-h" from help text

Hi,

Silvio Fricke wrote:

Show 9 quoted lines

> This regression was fixed in 91a640ffb6d9 ("ls-remote: a lone "-h" is
> asking for help") and the wrong help text was introduced in ba5f28bf79ea
> ("ls-remote: use parse-options api").
> This patch removes the "-h" on the help text.
>
> Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>
> ---
>  builtin/ls-remote.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Without this patch, I'm able to run

	git ls-remote -h .

This patch removes that support.  Intended?

Thanks and hope that helps, Jonathan

S. Fricke· Jun 28, 2017, 09:34 UTC · re: Jonathan Nieder · lore

Re: [PATCH 1/1] ls-remote: remove "-h" from help text

Hi Jonathan,

Show 8 quoted lines

> > This regression was fixed in 91a640ffb6d9 ("ls-remote: a lone "-h" is
> > [...]
> 
> Without this patch, I'm able to run
> 
> 	git ls-remote -h .
> 
> This patch removes that support.  Intended?

*hihi* okay it was to counter-intuitive for me. "91a640ffb6d" talks about this issue.

Thanks for enlightenment :-) Silvio

-- 
-- S. Fricke ---------------------------------------- silvio@port1024.net --
   Diplom-Informatiker (FH)
   Linux-Development                         Matrix: @silvio:port1024.net   
----------------------------------------------------------------------------