{"thread":{"id":"46274","subject":"[PATCH 1/1] ls-remote: remove \"-h\" from help text","startedAt":"2017-06-27T20:34:27Z","lastAt":"2017-06-28T09:34:43Z","messageCount":4,"participants":["Silvio Fricke","Jonathan Nieder","S. Fricke"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"323387","messageId":"c49b244848de20ad058a46023aeb266f4b361e4a.1498591103.git.silvio.fricke@gmail.com","threadId":"46274","inReplyTo":"cover.1498591103.git.silvio.fricke@gmail.com","subject":"[PATCH 1/1] ls-remote: remove \"-h\" from help text","fromName":"Silvio Fricke","fromEmail":"silvio.fricke@gmail.com","sentAt":"2017-06-27T20:34:11Z","receivedAt":"2017-06-27T20:34:27Z","isPatch":true,"sender":{"key":"silvio.fricke@gmail.com","avatar":"https://gravatar.com/avatar/a0b11e9a9041f02be2ae08f4e7bd1448f11254d73bdad8aef9ebc6ae6979e5c3?d=mp&s=160"},"body":"This regression was fixed in 91a640ffb6d9 (\"ls-remote: a lone \"-h\" is\nasking for help\") and the wrong help text was introduced in ba5f28bf79ea\n(\"ls-remote: use parse-options api\").\nThis patch removes the \"-h\" on the help text.\n\nSigned-off-by: Silvio Fricke <silvio.fricke@gmail.com>\n---\n builtin/ls-remote.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/builtin/ls-remote.c b/builtin/ls-remote.c\nindex b2d7d5ce6..cd54f7e98 100644\n--- a/builtin/ls-remote.c\n+++ b/builtin/ls-remote.c\n@@ -56,7 +56,7 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)\n \t\t\t   N_(\"path of git-upload-pack on the remote host\"),\n \t\t\t   PARSE_OPT_HIDDEN },\n \t\tOPT_BIT('t', \"tags\", &flags, N_(\"limit to tags\"), REF_TAGS),\n-\t\tOPT_BIT('h', \"heads\", &flags, N_(\"limit to heads\"), REF_HEADS),\n+\t\tOPT_BIT(0, \"heads\", &flags, N_(\"limit to heads\"), REF_HEADS),\n \t\tOPT_BIT(0, \"refs\", &flags, N_(\"do not show peeled tags\"), REF_NORMAL),\n \t\tOPT_BOOL(0, \"get-url\", &get_url,\n \t\t\t N_(\"take url.<base>.insteadOf into account\")),\n-- \n2.13.2\n\n"},{"id":"323388","messageId":"cover.1498591103.git.silvio.fricke@gmail.com","threadId":"46274","inReplyTo":null,"subject":"[PATCH 0/1] fix ls-remote help message","fromName":"Silvio Fricke","fromEmail":"silvio.fricke@gmail.com","sentAt":"2017-06-27T20:34:10Z","receivedAt":"2017-06-27T20:34:32Z","isPatch":true,"sender":{"key":"silvio.fricke@gmail.com","avatar":"https://gravatar.com/avatar/a0b11e9a9041f02be2ae08f4e7bd1448f11254d73bdad8aef9ebc6ae6979e5c3?d=mp&s=160"},"body":"Hi,\n\na small patch about a wrong help text. Please include when okay.\n\n\nBest Regards,\nSilvio\n\nSilvio Fricke (1):\n  ls-remote: remove \"-h\" from help text\n\n builtin/ls-remote.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n-- \n2.13.2\n\n"},{"id":"323391","messageId":"20170627210906.GJ161648@aiede.mtv.corp.google.com","threadId":"46274","inReplyTo":"c49b244848de20ad058a46023aeb266f4b361e4a.1498591103.git.silvio.fricke@gmail.com","subject":"Re: [PATCH 1/1] ls-remote: remove \"-h\" from help text","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-06-27T21:09:06Z","receivedAt":"2017-06-27T21:09:14Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Hi,\n\nSilvio Fricke wrote:\n\n> This regression was fixed in 91a640ffb6d9 (\"ls-remote: a lone \"-h\" is\n> asking for help\") and the wrong help text was introduced in ba5f28bf79ea\n> (\"ls-remote: use parse-options api\").\n> This patch removes the \"-h\" on the help text.\n>\n> Signed-off-by: Silvio Fricke <silvio.fricke@gmail.com>\n> ---\n>  builtin/ls-remote.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nWithout this patch, I'm able to run\n\n\tgit ls-remote -h .\n\nThis patch removes that support.  Intended?\n\nThanks and hope that helps,\nJonathan\n"},{"id":"323420","messageId":"20170628093435.GD4824@sfserver","threadId":"46274","inReplyTo":"20170627210906.GJ161648@aiede.mtv.corp.google.com","subject":"Re: [PATCH 1/1] ls-remote: remove \"-h\" from help text","fromName":"S. Fricke","fromEmail":"silvio.fricke@gmail.com","sentAt":"2017-06-28T09:34:35Z","receivedAt":"2017-06-28T09:34:43Z","isPatch":true,"sender":{"key":"silvio.fricke@gmail.com","avatar":"https://gravatar.com/avatar/a0b11e9a9041f02be2ae08f4e7bd1448f11254d73bdad8aef9ebc6ae6979e5c3?d=mp&s=160"},"body":"Hi Jonathan,\n\n\n> > This regression was fixed in 91a640ffb6d9 (\"ls-remote: a lone \"-h\" is\n> > [...]\n> \n> Without this patch, I'm able to run\n> \n> \tgit ls-remote -h .\n> \n> This patch removes that support.  Intended?\n\n*hihi* okay it was to counter-intuitive for me. \"91a640ffb6d\" talks about this\nissue.\n\nThanks for enlightenment :-)\nSilvio\n\n-- \n-- S. Fricke ---------------------------------------- silvio@port1024.net --\n   Diplom-Informatiker (FH)\n   Linux-Development                         Matrix: @silvio:port1024.net   \n----------------------------------------------------------------------------\n"}]}