threads / patch / 46183

patchsub-process: fix comment about api-sub-process.txt

Subject: [PATCH] sub-process: fix comment about api-sub-process.txt

## tl;dr

4 messages between Jun 14, 2017 and Jun 15, 2017. Diffs are folded; open one to read it.

replies: 3people: 4as markdown or json

Christian Couder· Jun 14, 2017, 15:12 UTC · lore

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---
 sub-process.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Show changes to sub-process.h +1 −1

diff --git a/sub-process.h b/sub-process.h
index 7d451e1cde..d9a45cd359 100644
--- a/sub-process.h
+++ b/sub-process.h
@@ -7,7 +7,7 @@
 
 /*
  * Generic implementation of background process infrastructure.
- * See Documentation/technical/api-background-process.txt.
+ * See: Documentation/technical/api-sub-process.txt
  */
 
  /* data structures */

-- 
2.13.1.453.g04e95ab038

Jonathan Nieder· Jun 14, 2017, 18:26 UTC · re: Christian Couder · lore

Re: [PATCH] sub-process: fix comment about api-sub-process.txt

Christian Couder wrote:

> Subject: sub-process: fix comment about api-sub-process.txt

nit: this one-line description doesn't describe what was wrong and is being fixed. I think something like

	sub-process: correct path to API docs in comment

would be easier to understand in "git log" output.

> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  sub-process.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

With or without such a tweak,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Show 13 quoted lines

> diff --git a/sub-process.h b/sub-process.h
> index 7d451e1cde..d9a45cd359 100644
> --- a/sub-process.h
> +++ b/sub-process.h
> @@ -7,7 +7,7 @@
>  
>  /*
>   * Generic implementation of background process infrastructure.
> - * See Documentation/technical/api-background-process.txt.
> + * See: Documentation/technical/api-sub-process.txt
>   */
>  
>   /* data structures */

Ben Peart· Jun 15, 2017, 14:10 UTC · re: Jonathan Nieder · lore

Re: [PATCH] sub-process: fix comment about api-sub-process.txt

On 6/14/2017 2:26 PM, Jonathan Nieder wrote:

Show 8 quoted lines

> Christian Couder wrote:
> 
>> Subject: sub-process: fix comment about api-sub-process.txt
> 
> nit: this one-line description doesn't describe what was wrong and is
> being fixed.  I think something like
> 
> 	sub-process: correct path to API docs in comment

Looks good to me.  Thanks for finding/fixing this.

Show 24 quoted lines

> 
> would be easier to understand in "git log" output.
> 
>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>> ---
>>   sub-process.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> With or without such a tweak,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> 
>> diff --git a/sub-process.h b/sub-process.h
>> index 7d451e1cde..d9a45cd359 100644
>> --- a/sub-process.h
>> +++ b/sub-process.h
>> @@ -7,7 +7,7 @@
>>   
>>   /*
>>    * Generic implementation of background process infrastructure.
>> - * See Documentation/technical/api-background-process.txt.
>> + * See: Documentation/technical/api-sub-process.txt
>>    */
>>   
>>    /* data structures */

Junio C Hamano· Jun 15, 2017, 21:34 UTC · re: Jonathan Nieder · lore

Re: [PATCH] sub-process: fix comment about api-sub-process.txt

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 10 quoted lines

> Christian Couder wrote:
>
>> Subject: sub-process: fix comment about api-sub-process.txt
>
> nit: this one-line description doesn't describe what was wrong and is
> being fixed.  I think something like
>
> 	sub-process: correct path to API docs in comment
>
> would be easier to understand in "git log" output.

Indeed.  Thanks.

Show 22 quoted lines

>
>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
>> ---
>>  sub-process.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> With or without such a tweak,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
>
>> diff --git a/sub-process.h b/sub-process.h
>> index 7d451e1cde..d9a45cd359 100644
>> --- a/sub-process.h
>> +++ b/sub-process.h
>> @@ -7,7 +7,7 @@
>>  
>>  /*
>>   * Generic implementation of background process infrastructure.
>> - * See Documentation/technical/api-background-process.txt.
>> + * See: Documentation/technical/api-sub-process.txt
>>   */
>>  
>>   /* data structures */