{"thread":{"id":"46183","subject":"[PATCH] sub-process: fix comment about api-sub-process.txt","startedAt":"2017-06-14T15:12:53Z","lastAt":"2017-06-15T21:34:12Z","messageCount":4,"participants":["Christian Couder","Jonathan Nieder","Ben Peart","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"322264","messageId":"20170614151225.31055-1-chriscool@tuxfamily.org","threadId":"46183","inReplyTo":null,"subject":"[PATCH] sub-process: fix comment about api-sub-process.txt","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2017-06-14T15:12:25Z","receivedAt":"2017-06-14T15:12:53Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n---\n sub-process.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/sub-process.h b/sub-process.h\nindex 7d451e1cde..d9a45cd359 100644\n--- a/sub-process.h\n+++ b/sub-process.h\n@@ -7,7 +7,7 @@\n \n /*\n  * Generic implementation of background process infrastructure.\n- * See Documentation/technical/api-background-process.txt.\n+ * See: Documentation/technical/api-sub-process.txt\n  */\n \n  /* data structures */\n-- \n2.13.1.453.g04e95ab038\n\n"},{"id":"322280","messageId":"20170614182607.GW133952@aiede.mtv.corp.google.com","threadId":"46183","inReplyTo":"20170614151225.31055-1-chriscool@tuxfamily.org","subject":"Re: [PATCH] sub-process: fix comment about api-sub-process.txt","fromName":"Jonathan Nieder","fromEmail":"jrnieder@gmail.com","sentAt":"2017-06-14T18:26:07Z","receivedAt":"2017-06-14T18:26:21Z","isPatch":true,"sender":{"key":"jrnieder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/281595?v=4"},"body":"Christian Couder wrote:\n\n> Subject: sub-process: fix comment about api-sub-process.txt\n\nnit: this one-line description doesn't describe what was wrong and is\nbeing fixed.  I think something like\n\n\tsub-process: correct path to API docs in comment\n\nwould be easier to understand in \"git log\" output.\n\n> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n> ---\n>  sub-process.h | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n\nWith or without such a tweak,\nReviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n\n> diff --git a/sub-process.h b/sub-process.h\n> index 7d451e1cde..d9a45cd359 100644\n> --- a/sub-process.h\n> +++ b/sub-process.h\n> @@ -7,7 +7,7 @@\n>  \n>  /*\n>   * Generic implementation of background process infrastructure.\n> - * See Documentation/technical/api-background-process.txt.\n> + * See: Documentation/technical/api-sub-process.txt\n>   */\n>  \n>   /* data structures */\n"},{"id":"322326","messageId":"62acd48f-8442-e9bf-9e96-ce9fa2228dac@gmail.com","threadId":"46183","inReplyTo":"20170614182607.GW133952@aiede.mtv.corp.google.com","subject":"Re: [PATCH] sub-process: fix comment about api-sub-process.txt","fromName":"Ben Peart","fromEmail":"peartben@gmail.com","sentAt":"2017-06-15T14:10:37Z","receivedAt":"2017-06-15T14:10:54Z","isPatch":true,"sender":{"key":"benpeart@microsoft.com","avatar":"https://avatars.githubusercontent.com/u/15252029?v=4"},"body":"\n\nOn 6/14/2017 2:26 PM, Jonathan Nieder wrote:\n> Christian Couder wrote:\n> \n>> Subject: sub-process: fix comment about api-sub-process.txt\n> \n> nit: this one-line description doesn't describe what was wrong and is\n> being fixed.  I think something like\n> \n> \tsub-process: correct path to API docs in comment\n\nLooks good to me.  Thanks for finding/fixing this.\n\n> \n> would be easier to understand in \"git log\" output.\n> \n>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n>> ---\n>>   sub-process.h | 2 +-\n>>   1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> With or without such a tweak,\n> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n> \n>> diff --git a/sub-process.h b/sub-process.h\n>> index 7d451e1cde..d9a45cd359 100644\n>> --- a/sub-process.h\n>> +++ b/sub-process.h\n>> @@ -7,7 +7,7 @@\n>>   \n>>   /*\n>>    * Generic implementation of background process infrastructure.\n>> - * See Documentation/technical/api-background-process.txt.\n>> + * See: Documentation/technical/api-sub-process.txt\n>>    */\n>>   \n>>    /* data structures */\n"},{"id":"322402","messageId":"xmqqmv99ylys.fsf@gitster.mtv.corp.google.com","threadId":"46183","inReplyTo":"20170614182607.GW133952@aiede.mtv.corp.google.com","subject":"Re: [PATCH] sub-process: fix comment about api-sub-process.txt","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-06-15T21:34:03Z","receivedAt":"2017-06-15T21:34:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jonathan Nieder <jrnieder@gmail.com> writes:\n\n> Christian Couder wrote:\n>\n>> Subject: sub-process: fix comment about api-sub-process.txt\n>\n> nit: this one-line description doesn't describe what was wrong and is\n> being fixed.  I think something like\n>\n> \tsub-process: correct path to API docs in comment\n>\n> would be easier to understand in \"git log\" output.\n\nIndeed.  Thanks.\n\n>\n>> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>\n>> ---\n>>  sub-process.h | 2 +-\n>>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> With or without such a tweak,\n> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>\n>\n>> diff --git a/sub-process.h b/sub-process.h\n>> index 7d451e1cde..d9a45cd359 100644\n>> --- a/sub-process.h\n>> +++ b/sub-process.h\n>> @@ -7,7 +7,7 @@\n>>  \n>>  /*\n>>   * Generic implementation of background process infrastructure.\n>> - * See Documentation/technical/api-background-process.txt.\n>> + * See: Documentation/technical/api-sub-process.txt\n>>   */\n>>  \n>>   /* data structures */\n"}]}