threads / discuss / 46040

Documentation issue: git-stash examples

Subject: Documentation issue: git-stash examples

## tl;dr

3 messages between May 25, 2017 and May 25, 2017.

replies: 2people: 2as markdown or json

Adrian Forbes· May 25, 2017, 09:52 UTC · lore

Some of the example commands in git-stash documentation should be written as comments rather than actual commands: https://cloud.githubusercontent.com/assets/24915363/26444394/5cf6a754-4190-11e7-845e-135288c8916e.png

For example, `$ edit emergency fix` should be `# ... edit emergency fix ...` like the other comments in the section.

It could be misleading for novices.
Adrian (github: @Solder-Soldier)
Jeff King· May 25, 2017, 18:30 UTC · re: Adrian Forbes · lore

Re: Documentation issue: git-stash examples

On Thu, May 25, 2017 at 09:52:42PM +1200, Adrian Forbes wrote:
Show 8 quoted lines
> Some of the example commands in git-stash documentation should be
> written as comments rather than actual commands:
> https://cloud.githubusercontent.com/assets/24915363/26444394/5cf6a754-4190-11e7-845e-135288c8916e.png
> 
> For example, `$ edit emergency fix` should be `# ... edit emergency
> fix ...` like the other comments in the section.
> 
> It could be misleading for novices.

Yeah, I think that's a good idea. Do you want to try your hand at a patch?

-Peff
Jeff King· May 25, 2017, 21:54 UTC · lore

Re: Documentation issue: git-stash examples

On Fri, May 26, 2017 at 08:37:41AM +1200, Adrian Forbes wrote:
> Yep, but how do I send it back to you? As a mail attachment?

Usually you'd send it to the list, with the commit message in the body and the patch inline below, as generated by "git format-patch".

Unfortunately gmail is notorious for corrupting whitespace in message bodies. You can use git-send-email to send the mails (but you'll need to configure your gmail smtp information; see the EXAMPLE section of "git help send-email").

Alternatively, you can make a pull request to https://github.com/git/git and then send it to the list via https://submitgit.herokuapp.com/.

-Peff

← back to recent threads