{"thread":{"id":"46040","subject":"Documentation issue: git-stash examples","startedAt":"2017-05-25T09:53:19Z","lastAt":"2017-05-25T21:54:14Z","messageCount":3,"participants":["Adrian Forbes","Jeff King"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"320703","messageId":"CAOJu4w-4eCkt9Co19BmyTQ7NF+rf23LU8ANCTCcmPP84efdjeA@mail.gmail.com","threadId":"46040","inReplyTo":null,"subject":"Documentation issue: git-stash examples","fromName":"Adrian Forbes","fromEmail":"forbesa06@gmail.com","sentAt":"2017-05-25T09:52:42Z","receivedAt":"2017-05-25T09:53:19Z","isPatch":false,"sender":{"key":"forbesa06@gmail.com","avatar":null},"body":"Some of the example commands in git-stash documentation should be\nwritten as comments rather than actual commands:\nhttps://cloud.githubusercontent.com/assets/24915363/26444394/5cf6a754-4190-11e7-845e-135288c8916e.png\n\nFor example, `$ edit emergency fix` should be `# ... edit emergency\nfix ...` like the other comments in the section.\n\nIt could be misleading for novices.\n\n\nAdrian (github: @Solder-Soldier)\n"},{"id":"320719","messageId":"20170525183037.tu7vaja25b7vgjfe@sigill.intra.peff.net","threadId":"46040","inReplyTo":"CAOJu4w-4eCkt9Co19BmyTQ7NF+rf23LU8ANCTCcmPP84efdjeA@mail.gmail.com","subject":"Re: Documentation issue: git-stash examples","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-05-25T18:30:38Z","receivedAt":"2017-05-25T18:30:45Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Thu, May 25, 2017 at 09:52:42PM +1200, Adrian Forbes wrote:\n\n> Some of the example commands in git-stash documentation should be\n> written as comments rather than actual commands:\n> https://cloud.githubusercontent.com/assets/24915363/26444394/5cf6a754-4190-11e7-845e-135288c8916e.png\n> \n> For example, `$ edit emergency fix` should be `# ... edit emergency\n> fix ...` like the other comments in the section.\n> \n> It could be misleading for novices.\n\nYeah, I think that's a good idea. Do you want to try your hand at a\npatch?\n\n-Peff\n"},{"id":"320771","messageId":"20170525215403.v5fzw7amicyftbgi@sigill.intra.peff.net","threadId":"46040","inReplyTo":"CAOJu4w-cghto=LAZKQPBDBHX=JOSbHGJiYawod+45_SzvhiuNg@mail.gmail.com","subject":"Re: Documentation issue: git-stash examples","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2017-05-25T21:54:04Z","receivedAt":"2017-05-25T21:54:14Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, May 26, 2017 at 08:37:41AM +1200, Adrian Forbes wrote:\n\n> Yep, but how do I send it back to you? As a mail attachment?\n\nUsually you'd send it to the list, with the commit message in the body\nand the patch inline below, as generated by \"git format-patch\".\n\nUnfortunately gmail is notorious for corrupting whitespace in message\nbodies. You can use git-send-email to send the mails (but you'll need to\nconfigure your gmail smtp information; see the EXAMPLE section of \"git\nhelp send-email\").\n\nAlternatively, you can make a pull request to https://github.com/git/git\nand then send it to the list via https://submitgit.herokuapp.com/.\n\n-Peff\n"}]}