[PATCH] remote.[ch]: parse_push_cas_option() can be static

Junio C Hamano· Mar 31, 2017, 20:25 UTC · lore

Since 068c77a5 ("builtin/send-pack.c: use parse_options API", 2015-08-19), there is no external user of this helper function.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 remote.c | 2 +-
 remote.h | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

Show changes to 2 files +1 −2

remote.c, remote.h

diff --git a/remote.c b/remote.c
index 68901b0070..fc2df99b81 100644
--- a/remote.c
+++ b/remote.c
@@ -2178,7 +2178,7 @@ static struct push_cas *add_cas_entry(struct push_cas_option *cas,
 	return entry;
 }
 
-int parse_push_cas_option(struct push_cas_option *cas, const char *arg, int unset)
+static int parse_push_cas_option(struct push_cas_option *cas, const char *arg, int unset)
 {
 	const char *colon;
 	struct push_cas *entry;
diff --git a/remote.h b/remote.h
index 02d66ceff5..19a4905da6 100644
--- a/remote.h
+++ b/remote.h
@@ -260,7 +260,6 @@ struct push_cas_option {
 };
 
 extern int parseopt_push_cas_option(const struct option *, const char *arg, int unset);
-extern int parse_push_cas_option(struct push_cas_option *, const char *arg, int unset);
 
 extern int is_empty_cas(const struct push_cas_option *);
 void apply_push_cas(struct push_cas_option *, struct remote *, struct ref *);

-- 
2.12.2-750-g6626ddbf7f

patchremote.[ch]: parse_push_cas_option() can be static