{"thread":{"id":"45572","subject":"[PATCH] remote.[ch]: parse_push_cas_option() can be static","startedAt":"2017-03-31T20:25:47Z","lastAt":"2017-03-31T20:25:47Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"315953","messageId":"xmqqbmshxkfx.fsf@gitster.mtv.corp.google.com","threadId":"45572","inReplyTo":null,"subject":"[PATCH] remote.[ch]: parse_push_cas_option() can be static","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-03-31T20:25:38Z","receivedAt":"2017-03-31T20:25:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Since 068c77a5 (\"builtin/send-pack.c: use parse_options API\",\n2015-08-19), there is no external user of this helper function.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n remote.c | 2 +-\n remote.h | 1 -\n 2 files changed, 1 insertion(+), 2 deletions(-)\n\ndiff --git a/remote.c b/remote.c\nindex 68901b0070..fc2df99b81 100644\n--- a/remote.c\n+++ b/remote.c\n@@ -2178,7 +2178,7 @@ static struct push_cas *add_cas_entry(struct push_cas_option *cas,\n \treturn entry;\n }\n \n-int parse_push_cas_option(struct push_cas_option *cas, const char *arg, int unset)\n+static int parse_push_cas_option(struct push_cas_option *cas, const char *arg, int unset)\n {\n \tconst char *colon;\n \tstruct push_cas *entry;\ndiff --git a/remote.h b/remote.h\nindex 02d66ceff5..19a4905da6 100644\n--- a/remote.h\n+++ b/remote.h\n@@ -260,7 +260,6 @@ struct push_cas_option {\n };\n \n extern int parseopt_push_cas_option(const struct option *, const char *arg, int unset);\n-extern int parse_push_cas_option(struct push_cas_option *, const char *arg, int unset);\n \n extern int is_empty_cas(const struct push_cas_option *);\n void apply_push_cas(struct push_cas_option *, struct remote *, struct ref *);\n-- \n2.12.2-750-g6626ddbf7f\n\n"}]}