threads / discuss / 45439

Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore

Subject: Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore

## tl;dr

3 messages between Mar 20, 2017 and Mar 21, 2017.

replies: 2people: 2as markdown or json

Sebastian Schuberth· Mar 20, 2017, 15:50 UTC · lore

Hi,

I'm using

$ git --version git version 2.12.0.windows.1

With this version, when I do a "reword" during an inteactive rebase session, the commit-msg hook doe snot seem to be triggered anymore. This was particularly useful to let Gerrit's commit-msg hook add missing ChangeId footers.

I can work-aorund the issue by doing an "edit" and "commit --amend".

Is anyone else seeing this?

Regards, Sebastian

Stefan Beller· Mar 20, 2017, 17:43 UTC · re: Sebastian Schuberth · lore

Re: Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore

On Mon, Mar 20, 2017 at 8:50 AM, Sebastian Schuberth <sschuberth@gmail.com> wrote:

Show 15 quoted lines

> Hi,
>
> I'm using
>
> $ git --version
> git version 2.12.0.windows.1
>
> With this version, when I do a "reword" during an inteactive rebase session,
> the commit-msg hook doe snot seem to be triggered anymore. This was
> particularly useful to let Gerrit's commit-msg hook add missing ChangeId
> footers.
>
> I can work-aorund the issue by doing an "edit" and "commit --amend".
>
> Is anyone else seeing this?

In 2.12 RelNotes:

 * "git rebase -i" starts using the recently updated "sequencer" code.

+cc Johannes

Sebastian Schuberth· Mar 21, 2017, 09:14 UTC · re: Stefan Beller · lore

Re: Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore

On 3/20/2017 18:43, Stefan Beller wrote:

Show 12 quoted lines

>> With this version, when I do a "reword" during an inteactive rebase session,
>> the commit-msg hook doe snot seem to be triggered anymore. This was
>> particularly useful to let Gerrit's commit-msg hook add missing ChangeId
>> footers.
>>
>> I can work-aorund the issue by doing an "edit" and "commit --amend".
>>
>> Is anyone else seeing this?
>
> In 2.12 RelNotes:
>
>  * "git rebase -i" starts using the recently updated "sequencer" code.

Thanks, that looks like a possible culprit. I can *not* reproduce the issue on Linux with "git version 2.12.1-382-gc0f9c70", thought. So either it's Windows-specific, or it has been fixed in 2.12.1 already.

Regards, Sebastian