{"thread":{"id":"45439","subject":"Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore","startedAt":"2017-03-20T16:09:13Z","lastAt":"2017-03-21T09:14:27Z","messageCount":3,"participants":["Sebastian Schuberth","Stefan Beller"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"314659","messageId":"oaotoa$qkp$1@blaine.gmane.org","threadId":"45439","inReplyTo":null,"subject":"Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2017-03-20T15:50:41Z","receivedAt":"2017-03-20T16:09:13Z","isPatch":false,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"Hi,\n\nI'm using\n\n$ git --version\ngit version 2.12.0.windows.1\n\nWith this version, when I do a \"reword\" during an inteactive rebase \nsession, the commit-msg hook doe snot seem to be triggered anymore. This \nwas particularly useful to let Gerrit's commit-msg hook add missing \nChangeId footers.\n\nI can work-aorund the issue by doing an \"edit\" and \"commit --amend\".\n\nIs anyone else seeing this?\n\nRegards,\nSebastian\n\n"},{"id":"314692","messageId":"CAGZ79kY7bCt_3Fse_Qi43Aej=MgN1ABLTx7eLmPCs+aP2e9ZwQ@mail.gmail.com","threadId":"45439","inReplyTo":"oaotoa$qkp$1@blaine.gmane.org","subject":"Re: Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore","fromName":"Stefan Beller","fromEmail":"sbeller@google.com","sentAt":"2017-03-20T17:43:55Z","receivedAt":"2017-03-20T17:44:05Z","isPatch":false,"sender":{"key":"stefanbeller@gmail.com","avatar":"https://avatars.githubusercontent.com/u/455868?v=4"},"body":"On Mon, Mar 20, 2017 at 8:50 AM, Sebastian Schuberth\n<sschuberth@gmail.com> wrote:\n> Hi,\n>\n> I'm using\n>\n> $ git --version\n> git version 2.12.0.windows.1\n>\n> With this version, when I do a \"reword\" during an inteactive rebase session,\n> the commit-msg hook doe snot seem to be triggered anymore. This was\n> particularly useful to let Gerrit's commit-msg hook add missing ChangeId\n> footers.\n>\n> I can work-aorund the issue by doing an \"edit\" and \"commit --amend\".\n>\n> Is anyone else seeing this?\n\nIn 2.12 RelNotes:\n\n * \"git rebase -i\" starts using the recently updated \"sequencer\" code.\n\n+cc Johannes\n"},{"id":"314782","messageId":"1f14be35-4688-7d0b-bb84-bfc901dba807@gmail.com","threadId":"45439","inReplyTo":"CAGZ79kY7bCt_3Fse_Qi43Aej=MgN1ABLTx7eLmPCs+aP2e9ZwQ@mail.gmail.com","subject":"Re: Regression: Reword during rebase -i does not seem to trigger commit-msg hook anymore","fromName":"Sebastian Schuberth","fromEmail":"sschuberth@gmail.com","sentAt":"2017-03-21T09:14:06Z","receivedAt":"2017-03-21T09:14:27Z","isPatch":false,"sender":{"key":"sschuberth@gmail.com","avatar":"https://avatars.githubusercontent.com/u/349154?v=4"},"body":"On 3/20/2017 18:43, Stefan Beller wrote:\n\n>> With this version, when I do a \"reword\" during an inteactive rebase session,\n>> the commit-msg hook doe snot seem to be triggered anymore. This was\n>> particularly useful to let Gerrit's commit-msg hook add missing ChangeId\n>> footers.\n>>\n>> I can work-aorund the issue by doing an \"edit\" and \"commit --amend\".\n>>\n>> Is anyone else seeing this?\n>\n> In 2.12 RelNotes:\n>\n>  * \"git rebase -i\" starts using the recently updated \"sequencer\" code.\n\nThanks, that looks like a possible culprit. I can *not* reproduce the \nissue on Linux with \"git version 2.12.1-382-gc0f9c70\", thought. So \neither it's Windows-specific, or it has been fixed in 2.12.1 already.\n\nRegards,\nSebastian\n\n\n\n"}]}