threads / patch / 45369

patchv2 adding built-in driver for javascript

Subject: [PATCH]v2 adding built-in driver for javascript

## tl;dr

5 messages between Mar 13, 2017 and Mar 16, 2017. Diffs are folded; open one to read it.

replies: 4people: 4as markdown or json

sourav mondal· Mar 13, 2017, 20:08 UTC · lore
javascript is one of the famous langugae,it's needs a built-in driver. As it was not present in the userdiff & this leads to the patch.
	first line consists of some of the well used javascript keywords.statements in js use one or many keywords like variable declaration, function definition, logical opreation etc.The following line is for statements of type object.method() & it is expected to end any statement using ";". The word_regex in js is usual alpha-numeric.last two line shows all the different types of opreators in js and different types of number system used in js are also defined.     
Signed-off-by: sourav mondal <souravcristiano502@gmail.com>
---
I'm working on "Add more built-in driver for userdiff" as my microproject for Gsoc17. This patch is for javascript which is one of the popular language at this time. I'm willing to add more driver for other laguage that isn't present in userdiff.c and again I'm willing to participate in Gsoc17 with git. I'm eager to know about this patch.
thanks & regards
sourav
   
 userdiff.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
Show changes to userdiff.c +10 −0
diff --git a/userdiff.c b/userdiff.c
index 8b732e4..2f8e078 100644
--- a/userdiff.c
+++ b/userdiff.c
@@ -160,6 +160,16 @@ IPATTERN("css",
 	 "-?[_a-zA-Z][-_a-zA-Z0-9]*" /* identifiers */
 	 "|-?[0-9]+|\\#[0-9a-fA-F]+" /* numbers */
 ),
+PATTERNS("javascript",
+	 /* keywords/patterns*/
+	 "^[ \t]*(var|if|else|for|do|while|switch|case|function|break|continue|new|return|class|super|instanceof)"
+	 "^[ \t]*(([a-zA-Z_][a-zA-Z0-9])*[ \t]*\\.?[a-zA-Z_]*\\(\\)[ \t]*);$",
+	 /* word_regex */
+	 "[a-zA-Z_][a-zA-Z0-9]*"
+	 "|[-+0-9.eE]+|0[bB]?|[xX]?|o?[0-9a-fA-F]+"
+	 "|[==-+*/%<>&|!**=^]="
+	 "|--|\\+\\+|<<=?|>>>?=?|&&|\|\|"
+),
 { "default", NULL, -1, { NULL, 0 } },
 };
 #undef PATTERNS

-- 
2.9.3
Christian Couder· Mar 16, 2017, 18:54 UTC · re: sourav mondal · lore

Re: [PATCH]v2 adding built-in driver for javascript

On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal <souravcristiano502@gmail.com> wrote:

> javascript is one of the famous langugae,it's needs a built-in driver.

Please use "Javascript" instead of "javascript". There is a typo in "language" above, also maybe "it needs" instead of "it's needs", and please add a blank space before it.

> As it was not present in the userdiff & this leads to the patch.
Maybe "," instead of "&".
>         first line consists of some of the well used javascript keywords.statements

"First" instead of "first" and no space before it, but a space and an uppercase letter at the beginning of "statements".

> in js use one or many keywords like variable declaration, function definition, logical opreation etc.The
Typo in "opreation" and please add a space before "The".

I am stopping here but there are also typos and things to improve in the rest of the commit message.

Junio C Hamano· Mar 16, 2017, 18:56 UTC · re: Christian Couder · lore

Re: [PATCH]v2 adding built-in driver for javascript

Christian Couder <christian.couder@gmail.com> writes:
Show 5 quoted lines
> On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal
> <souravcristiano502@gmail.com> wrote:
>> javascript is one of the famous langugae,it's needs a built-in driver.
>
> Please use "Javascript" instead of "javascript".

While we are typo-spotting ;-) Wikipedia seems to prefer to spell it "JavaScript".

Christian Couder· Mar 16, 2017, 19:03 UTC · re: Junio C Hamano · lore

Re: [PATCH]v2 adding built-in driver for javascript

On Thu, Mar 16, 2017 at 7:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 10 quoted lines
> Christian Couder <christian.couder@gmail.com> writes:
>
>> On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal
>> <souravcristiano502@gmail.com> wrote:
>>> javascript is one of the famous langugae,it's needs a built-in driver.
>>
>> Please use "Javascript" instead of "javascript".
>
> While we are typo-spotting ;-) Wikipedia seems to prefer to spell it
> "JavaScript".

Yeah thanks, and while at it, the "v2" in the subject should be inside the square brackets around "PATCH".

Brandon Williams· Mar 16, 2017, 19:06 UTC · re: Christian Couder · lore

Re: [PATCH]v2 adding built-in driver for javascript

On 03/16, Christian Couder wrote:
Show 14 quoted lines
> On Thu, Mar 16, 2017 at 7:56 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > Christian Couder <christian.couder@gmail.com> writes:
> >
> >> On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal
> >> <souravcristiano502@gmail.com> wrote:
> >>> javascript is one of the famous langugae,it's needs a built-in driver.
> >>
> >> Please use "Javascript" instead of "javascript".
> >
> > While we are typo-spotting ;-) Wikipedia seems to prefer to spell it
> > "JavaScript".
> 
> Yeah thanks, and while at it, the "v2" in the subject should be inside
> the square brackets around "PATCH".

You can use the --reroll-count <n> option to format-patch to have format patch place the v<n> inside the bracketed PATCH section.

-- 
Brandon Williams

← back to recent threads