{"thread":{"id":"45369","subject":"[PATCH]v2 adding built-in driver for javascript","startedAt":"2017-03-13T20:09:39Z","lastAt":"2017-03-16T19:06:39Z","messageCount":5,"participants":["sourav mondal","Christian Couder","Junio C Hamano","Brandon Williams"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"313941","messageId":"20170313200854.6905-1-souravcristiano502@gmail.com","threadId":"45369","inReplyTo":null,"subject":"[PATCH]v2 adding built-in driver for javascript","fromName":"sourav mondal","fromEmail":"souravcristiano502@gmail.com","sentAt":"2017-03-13T20:08:54Z","receivedAt":"2017-03-13T20:09:39Z","isPatch":true,"sender":{"key":"souravcristiano502@gmail.com","avatar":null},"body":"javascript is one of the famous langugae,it's needs a built-in driver. As it was not present in the userdiff & this leads to the patch.\n\tfirst line consists of some of the well used javascript keywords.statements in js use one or many keywords like variable declaration, function definition, logical opreation etc.The following line is for statements of type object.method() & it is expected to end any statement using \";\". The word_regex in js is usual alpha-numeric.last two line shows all the different types of opreators in js and different types of number system used in js are also defined. \n\nSigned-off-by: sourav mondal \n---\n\nI'm working on \"Add more built-in driver for userdiff\" as my microproject for Gsoc17. This patch is for javascript which is one of the popular language at this time. I'm willing to add more driver for other laguage that isn't present in userdiff.c and again I'm willing to participate in Gsoc17 with git. I'm eager to know about this patch.\n\nthanks & regards\nsourav\n \n userdiff.c | 10 ++++++++++\n 1 file changed, 10 insertions(+)\n\ndiff --git a/userdiff.c b/userdiff.c\nindex 8b732e4..2f8e078 100644\n--- a/userdiff.c\n+++ b/userdiff.c\n@@ -160,6 +160,16 @@ IPATTERN(\"css\",\n \t \"-?[_a-zA-Z][-_a-zA-Z0-9]*\" /* identifiers */\n \t \"|-?[0-9]+|\\\\#[0-9a-fA-F]+\" /* numbers */\n ),\n+PATTERNS(\"javascript\",\n+\t /* keywords/patterns*/\n+\t \"^[ \\t]*(var|if|else|for|do|while|switch|case|function|break|continue|new|return|class|super|instanceof)\"\n+\t \"^[ \\t]*(([a-zA-Z_][a-zA-Z0-9])*[ \\t]*\\\\.?[a-zA-Z_]*\\\\(\\\\)[ \\t]*);$\",\n+\t /* word_regex */\n+\t \"[a-zA-Z_][a-zA-Z0-9]*\"\n+\t \"|[-+0-9.eE]+|0[bB]?|[xX]?|o?[0-9a-fA-F]+\"\n+\t \"|[==-+*/%<>&|!**=^]=\"\n+\t \"|--|\\\\+\\\\+|<<=?|>>>?=?|&&|\\|\\|\"\n+),\n { \"default\", NULL, -1, { NULL, 0 } },\n };\n #undef PATTERNS\n-- \n2.9.3\n\n"},{"id":"314241","messageId":"CAP8UFD3toXk36wmJu+EeBnTvCa0yHWqCmQOfoJ0+2QTs8MpB-A@mail.gmail.com","threadId":"45369","inReplyTo":"20170313200854.6905-1-souravcristiano502@gmail.com","subject":"Re: [PATCH]v2 adding built-in driver for javascript","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2017-03-16T18:54:46Z","receivedAt":"2017-03-16T18:54:52Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal\n wrote:\n> javascript is one of the famous langugae,it's needs a built-in driver.\n\nPlease use \"Javascript\" instead of \"javascript\".\nThere is a typo in \"language\" above, also maybe \"it needs\" instead of\n\"it's needs\", and please add a blank space before it.\n\n> As it was not present in the userdiff & this leads to the patch.\n\nMaybe \",\" instead of \"&\".\n\n> first line consists of some of the well used javascript keywords.statements\n\n\"First\" instead of \"first\" and no space before it, but a space and an\nuppercase letter at the beginning of \"statements\".\n\n> in js use one or many keywords like variable declaration, function definition, logical opreation etc.The\n\nTypo in \"opreation\" and please add a space before \"The\".\n\nI am stopping here but there are also typos and things to improve in\nthe rest of the commit message.\n"},{"id":"314242","messageId":"xmqqo9x1aw44.fsf@gitster.mtv.corp.google.com","threadId":"45369","inReplyTo":"CAP8UFD3toXk36wmJu+EeBnTvCa0yHWqCmQOfoJ0+2QTs8MpB-A@mail.gmail.com","subject":"Re: [PATCH]v2 adding built-in driver for javascript","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2017-03-16T18:56:43Z","receivedAt":"2017-03-16T18:56:50Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Christian Couder writes:\n\n> On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal\n> wrote:\n>> javascript is one of the famous langugae,it's needs a built-in driver.\n>\n> Please use \"Javascript\" instead of \"javascript\".\n\nWhile we are typo-spotting ;-) Wikipedia seems to prefer to spell it\n\"JavaScript\".\n"},{"id":"314244","messageId":"CAP8UFD0Exw4GPeat+xCgJdgd1E0dy0tu8JVpzkq=DnvGWArFDQ@mail.gmail.com","threadId":"45369","inReplyTo":"xmqqo9x1aw44.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH]v2 adding built-in driver for javascript","fromName":"Christian Couder","fromEmail":"christian.couder@gmail.com","sentAt":"2017-03-16T19:03:34Z","receivedAt":"2017-03-16T19:03:46Z","isPatch":true,"sender":{"key":"christian.couder@gmail.com","avatar":"https://avatars.githubusercontent.com/u/208954?v=4"},"body":"On Thu, Mar 16, 2017 at 7:56 PM, Junio C Hamano wrote:\n> Christian Couder writes:\n>\n>> On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal\n>> wrote:\n>>> javascript is one of the famous langugae,it's needs a built-in driver.\n>>\n>> Please use \"Javascript\" instead of \"javascript\".\n>\n> While we are typo-spotting ;-) Wikipedia seems to prefer to spell it\n> \"JavaScript\".\n\nYeah thanks, and while at it, the \"v2\" in the subject should be inside\nthe square brackets around \"PATCH\".\n"},{"id":"314245","messageId":"20170316190631.GA168812@google.com","threadId":"45369","inReplyTo":"CAP8UFD0Exw4GPeat+xCgJdgd1E0dy0tu8JVpzkq=DnvGWArFDQ@mail.gmail.com","subject":"Re: [PATCH]v2 adding built-in driver for javascript","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2017-03-16T19:06:31Z","receivedAt":"2017-03-16T19:06:39Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"On 03/16, Christian Couder wrote:\n> On Thu, Mar 16, 2017 at 7:56 PM, Junio C Hamano wrote:\n> > Christian Couder writes:\n> >\n> >> On Mon, Mar 13, 2017 at 9:08 PM, sourav mondal\n> >> wrote:\n> >>> javascript is one of the famous langugae,it's needs a built-in driver.\n> >>\n> >> Please use \"Javascript\" instead of \"javascript\".\n> >\n> > While we are typo-spotting ;-) Wikipedia seems to prefer to spell it\n> > \"JavaScript\".\n> \n> Yeah thanks, and while at it, the \"v2\" in the subject should be inside\n> the square brackets around \"PATCH\".\n\nYou can use the --reroll-count option to format-patch to have format\npatch place the v inside the bracketed PATCH section.\n\n-- \nBrandon Williams\n"}]}