threads / patch / 45168

patchsubmodule.c: Add missing quotation marks

Subject: [PATCH] submodule.c: Add missing quotation marks

## tl;dr

2 messages between Feb 17, 2017 and Feb 17, 2017. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Phillip Sz· Feb 17, 2017, 23:04 UTC · lore

Hi,

just found this while translating, sorry if this is intended.

Best regards,

Phillip
---
 submodule.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Show changes to submodule.c +2 −2

diff --git a/submodule.c b/submodule.c
index 3b98766a6..b064ed080 100644
--- a/submodule.c
+++ b/submodule.c
@@ -1181,7 +1181,7 @@ int bad_to_remove_submodule(const char *path, unsigned flags)
 	cp.dir = path;
 	if (start_command(&cp)) {
 		if (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)
-			die(_("could not start 'git status in submodule '%s'"),
+			die(_("could not start 'git status' in submodule '%s'"),
 				path);
 		ret = -1;
 		goto out;
@@ -1194,7 +1194,7 @@ int bad_to_remove_submodule(const char *path, unsigned flags)
 
 	if (finish_command(&cp)) {
 		if (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)
-			die(_("could not run 'git status in submodule '%s'"),
+			die(_("could not run 'git status' in submodule '%s'"),
 				path);
 		ret = -1;
 	}

-- 
2.11.1

Brandon Williams· Feb 17, 2017, 23:07 UTC · re: Phillip Sz · lore

Re: [PATCH] submodule.c: Add missing quotation marks

On 02/18, Phillip Sz wrote:

Show 7 quoted lines

> Hi,
> 
> just found this while translating, sorry if this is intended.
> 
> Best regards,
> 
> Phillip

Definitely not intended.  Thanks for catching that.

Show 29 quoted lines

> ---
>  submodule.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/submodule.c b/submodule.c
> index 3b98766a6..b064ed080 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -1181,7 +1181,7 @@ int bad_to_remove_submodule(const char *path, unsigned flags)
>  	cp.dir = path;
>  	if (start_command(&cp)) {
>  		if (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)
> -			die(_("could not start 'git status in submodule '%s'"),
> +			die(_("could not start 'git status' in submodule '%s'"),
>  				path);
>  		ret = -1;
>  		goto out;
> @@ -1194,7 +1194,7 @@ int bad_to_remove_submodule(const char *path, unsigned flags)
>  
>  	if (finish_command(&cp)) {
>  		if (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)
> -			die(_("could not run 'git status in submodule '%s'"),
> +			die(_("could not run 'git status' in submodule '%s'"),
>  				path);
>  		ret = -1;
>  	}
> -- 
> 2.11.1
>

-- 
Brandon Williams