{"thread":{"id":"45168","subject":"[PATCH] submodule.c: Add missing quotation marks","startedAt":"2017-02-17T23:05:54Z","lastAt":"2017-02-17T23:07:15Z","messageCount":2,"participants":["Phillip Sz","Brandon Williams"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"311969","messageId":"20170217230433.23336-1-phillip.szelat@gmail.com","threadId":"45168","inReplyTo":null,"subject":"[PATCH] submodule.c: Add missing quotation marks","fromName":"Phillip Sz","fromEmail":"phillip.szelat@gmail.com","sentAt":"2017-02-17T23:04:33Z","receivedAt":"2017-02-17T23:05:54Z","isPatch":true,"sender":{"key":"phillip.szelat@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4458478?v=4"},"body":"Hi,\n\njust found this while translating, sorry if this is intended.\n\nBest regards,\n\nPhillip\n---\n submodule.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/submodule.c b/submodule.c\nindex 3b98766a6..b064ed080 100644\n--- a/submodule.c\n+++ b/submodule.c\n@@ -1181,7 +1181,7 @@ int bad_to_remove_submodule(const char *path, unsigned flags)\n \tcp.dir = path;\n \tif (start_command(&cp)) {\n \t\tif (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)\n-\t\t\tdie(_(\"could not start 'git status in submodule '%s'\"),\n+\t\t\tdie(_(\"could not start 'git status' in submodule '%s'\"),\n \t\t\t\tpath);\n \t\tret = -1;\n \t\tgoto out;\n@@ -1194,7 +1194,7 @@ int bad_to_remove_submodule(const char *path, unsigned flags)\n \n \tif (finish_command(&cp)) {\n \t\tif (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)\n-\t\t\tdie(_(\"could not run 'git status in submodule '%s'\"),\n+\t\t\tdie(_(\"could not run 'git status' in submodule '%s'\"),\n \t\t\t\tpath);\n \t\tret = -1;\n \t}\n-- \n2.11.1\n\n"},{"id":"311970","messageId":"20170217230708.GA13751@google.com","threadId":"45168","inReplyTo":"20170217230433.23336-1-phillip.szelat@gmail.com","subject":"Re: [PATCH] submodule.c: Add missing quotation marks","fromName":"Brandon Williams","fromEmail":"bmwill@google.com","sentAt":"2017-02-17T23:07:08Z","receivedAt":"2017-02-17T23:07:15Z","isPatch":true,"sender":{"key":"bwilliams.eng@gmail.com","avatar":null},"body":"On 02/18, Phillip Sz wrote:\n> Hi,\n> \n> just found this while translating, sorry if this is intended.\n> \n> Best regards,\n> \n> Phillip\n\nDefinitely not intended.  Thanks for catching that.\n\n> ---\n>  submodule.c | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/submodule.c b/submodule.c\n> index 3b98766a6..b064ed080 100644\n> --- a/submodule.c\n> +++ b/submodule.c\n> @@ -1181,7 +1181,7 @@ int bad_to_remove_submodule(const char *path, unsigned flags)\n>  \tcp.dir = path;\n>  \tif (start_command(&cp)) {\n>  \t\tif (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)\n> -\t\t\tdie(_(\"could not start 'git status in submodule '%s'\"),\n> +\t\t\tdie(_(\"could not start 'git status' in submodule '%s'\"),\n>  \t\t\t\tpath);\n>  \t\tret = -1;\n>  \t\tgoto out;\n> @@ -1194,7 +1194,7 @@ int bad_to_remove_submodule(const char *path, unsigned flags)\n>  \n>  \tif (finish_command(&cp)) {\n>  \t\tif (flags & SUBMODULE_REMOVAL_DIE_ON_ERROR)\n> -\t\t\tdie(_(\"could not run 'git status in submodule '%s'\"),\n> +\t\t\tdie(_(\"could not run 'git status' in submodule '%s'\"),\n>  \t\t\t\tpath);\n>  \t\tret = -1;\n>  \t}\n> -- \n> 2.11.1\n> \n\n-- \nBrandon Williams\n"}]}