threads / patch / 4500

patch, 8 partsMake a couple of commands builtin

Subject: [PATCH 0/8] Make a couple of commands builtin

## tl;dr

3 messages between Jun 13, 2006 and Jun 13, 2006. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Lukas Sandström· Jun 13, 2006, 20:21 UTC · lore

This patchseries has the ultimate goal of making git-am a builtin.

The version of git-am I'm sending out makes quite heavy use of system(), but I think that can be worked around. I just haven't figured out how, yet.

/Lukas

Timo Hirvonen· Jun 13, 2006, 21:54 UTC · re: Lukas Sandström · lore

Re: [PATCH 0/8] Make a couple of commands builtin

Lukas Sandström <lukass@etek.chalmers.se> wrote:

Show 6 quoted lines

> This patchseries has the ultimate goal of making
> git-am a builtin.
> 
> The version of git-am I'm sending out makes quite heavy
> use of system(), but I think that can be worked around.
> I just haven't figured out how, yet.

I don't think git-stripspace needs to be a built-in. It doesn't even depend on git. It is just a tiny helper program used by git-am, git-applymbox, git-commit and git-tag. If all these commands are made built-in then git-stripspace becomes useless.

-- 
http://onion.dynserv.net/~timo/

Lukas Sandström· Jun 13, 2006, 22:03 UTC · re: Timo Hirvonen · lore

Re: [PATCH 0/8] Make a couple of commands builtin

Timo Hirvonen wrote:

Show 14 quoted lines

> Lukas Sandström <lukass@etek.chalmers.se> wrote:
> 
>> This patchseries has the ultimate goal of making
>> git-am a builtin.
>>
>> The version of git-am I'm sending out makes quite heavy
>> use of system(), but I think that can be worked around.
>> I just haven't figured out how, yet.
> 
> I don't think git-stripspace needs to be a built-in.  It doesn't even
> depend on git.  It is just a tiny helper program used by git-am,
> git-applymbox, git-commit and git-tag.  If all these commands are made
> built-in then git-stripspace becomes useless.
>

The reason I made it builtin was to de able to call it easily from git-am.

As you say, once all the users are builtin it could be removed, unless somone is using it in their scripts.

/Lukas