threads / patch / 44885

patchrequest-pull: drop old USAGE stuff

Subject: [PATCH] request-pull: drop old USAGE stuff

## tl;dr

3 messages between Jan 15, 2017 and Jan 16, 2017. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Wolfram Sang· Jan 15, 2017, 17:46 UTC · lore

request-pull uses OPTIONS_SPEC, so no need for (meanwhile incomplete) USAGE and LONG_USAGE anymore.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

 git-request-pull.sh |    3 ---
 1 file changed, 3 deletions(-)

Show changes to diff +0 −3

Index: git-2.11.0/git-request-pull.sh
===================================================================
--- git-2.11.0.orig/git-request-pull.sh
+++ git-2.11.0/git-request-pull.sh
@@ -4,9 +4,6 @@
 # This file is licensed under the GPL v2, or a later version
 # at the discretion of Linus Torvalds.
 
-USAGE='<start> <url> [<end>]'
-LONG_USAGE='Summarizes the changes between two commits to the standard output,
-and includes the given URL in the generated summary.'
 SUBDIRECTORY_OK='Yes'
 OPTIONS_KEEPDASHDASH=
 OPTIONS_STUCKLONG=

Junio C Hamano· Jan 16, 2017, 00:23 UTC · re: Wolfram Sang · lore

Re: [PATCH] request-pull: drop old USAGE stuff

Wolfram Sang <wsa@the-dreams.de> writes:

Show 5 quoted lines

> request-pull uses OPTIONS_SPEC, so no need for (meanwhile incomplete)
> USAGE and LONG_USAGE anymore.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---

Makes sense. These are not used anywhere after we switched to use parse-options.

Thanks.

Show 18 quoted lines

>
>  git-request-pull.sh |    3 ---
>  1 file changed, 3 deletions(-)
>
> Index: git-2.11.0/git-request-pull.sh
> ===================================================================
> --- git-2.11.0.orig/git-request-pull.sh
> +++ git-2.11.0/git-request-pull.sh
> @@ -4,9 +4,6 @@
>  # This file is licensed under the GPL v2, or a later version
>  # at the discretion of Linus Torvalds.
>  
> -USAGE='<start> <url> [<end>]'
> -LONG_USAGE='Summarizes the changes between two commits to the standard output,
> -and includes the given URL in the generated summary.'
>  SUBDIRECTORY_OK='Yes'
>  OPTIONS_KEEPDASHDASH=
>  OPTIONS_STUCKLONG=

Jeff King· Jan 16, 2017, 23:51 UTC · re: Junio C Hamano · lore

Re: [PATCH] request-pull: drop old USAGE stuff

On Sun, Jan 15, 2017 at 04:23:02PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> Wolfram Sang <wsa@the-dreams.de> writes:
> 
> > request-pull uses OPTIONS_SPEC, so no need for (meanwhile incomplete)
> > USAGE and LONG_USAGE anymore.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
> 
> Makes sense.  These are not used anywhere after we switched to use
> parse-options.

It does seem a shame that parse-options does not show this explanatory text. But I guess nobody really cares that much, and you can always use "--help" to get even more details.

-Peff