# [PATCH] request-pull: drop old USAGE stuff

3 messages from 2017-01-15 to 2017-01-16. Participants: Wolfram Sang, Junio C Hamano, Jeff King.
Thread: https://gitlist.dev/t/44885

## Wolfram Sang, 2017-01-15 17:46

Subject: [PATCH] request-pull: drop old USAGE stuff
Message-ID: <20170115174635.2422-1-wsa@the-dreams.de>
URL: https://gitlist.dev/e/20170115174635.2422-1-wsa%40the-dreams.de

```
request-pull uses OPTIONS_SPEC, so no need for (meanwhile incomplete)
USAGE and LONG_USAGE anymore.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

 git-request-pull.sh |    3 ---
 1 file changed, 3 deletions(-)

Index: git-2.11.0/git-request-pull.sh
===================================================================
--- git-2.11.0.orig/git-request-pull.sh
+++ git-2.11.0/git-request-pull.sh
@@ -4,9 +4,6 @@
 # This file is licensed under the GPL v2, or a later version
 # at the discretion of Linus Torvalds.
 
-USAGE='<start> <url> [<end>]'
-LONG_USAGE='Summarizes the changes between two commits to the standard output,
-and includes the given URL in the generated summary.'
 SUBDIRECTORY_OK='Yes'
 OPTIONS_KEEPDASHDASH=
 OPTIONS_STUCKLONG=

```

## Junio C Hamano, 2017-01-16 00:23

Subject: Re: [PATCH] request-pull: drop old USAGE stuff
Message-ID: <xmqqr343c0pl.fsf@gitster.mtv.corp.google.com>
URL: https://gitlist.dev/e/xmqqr343c0pl.fsf%40gitster.mtv.corp.google.com
In-Reply-To: <20170115174635.2422-1-wsa@the-dreams.de>

```
Wolfram Sang <wsa@the-dreams.de> writes:

> request-pull uses OPTIONS_SPEC, so no need for (meanwhile incomplete)
> USAGE and LONG_USAGE anymore.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---

Makes sense.  These are not used anywhere after we switched to use
parse-options.

Thanks.

>
>  git-request-pull.sh |    3 ---
>  1 file changed, 3 deletions(-)
>
> Index: git-2.11.0/git-request-pull.sh
> ===================================================================
> --- git-2.11.0.orig/git-request-pull.sh
> +++ git-2.11.0/git-request-pull.sh
> @@ -4,9 +4,6 @@
>  # This file is licensed under the GPL v2, or a later version
>  # at the discretion of Linus Torvalds.
>  
> -USAGE='<start> <url> [<end>]'
> -LONG_USAGE='Summarizes the changes between two commits to the standard output,
> -and includes the given URL in the generated summary.'
>  SUBDIRECTORY_OK='Yes'
>  OPTIONS_KEEPDASHDASH=
>  OPTIONS_STUCKLONG=

```

## Jeff King, 2017-01-16 23:51

Subject: Re: [PATCH] request-pull: drop old USAGE stuff
Message-ID: <20170116235131.kyxzcsslr4x7ppev@sigill.intra.peff.net>
URL: https://gitlist.dev/e/20170116235131.kyxzcsslr4x7ppev%40sigill.intra.peff.net
In-Reply-To: <xmqqr343c0pl.fsf@gitster.mtv.corp.google.com>

```
On Sun, Jan 15, 2017 at 04:23:02PM -0800, Junio C Hamano wrote:

> Wolfram Sang <wsa@the-dreams.de> writes:
> 
> > request-pull uses OPTIONS_SPEC, so no need for (meanwhile incomplete)
> > USAGE and LONG_USAGE anymore.
> >
> > Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> > ---
> 
> Makes sense.  These are not used anywhere after we switched to use
> parse-options.

It does seem a shame that parse-options does not show this explanatory
text. But I guess nobody really cares that much, and you can always use
"--help" to get even more details.

-Peff

```