threads / patch / 44861

patchimap-send.c: Avoid deprecated openssl 1.1.0 API

Subject: [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API

## tl;dr

3 messages between Jan 12, 2017 and Jan 12, 2017. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

eroen· Jan 12, 2017, 10:42 UTC · lore

Library initialization functions are deprecated in openssl 1.1.0 API, as initialization is handled by openssl internally.

Symbols for deprecated functions are not exported if openssl is built with `--api=1.1 disable-deprecated`, so their use will cause a build failure.

Reported-by: Lars Wendler (Polynomial-C)

X-Gentoo-Bug: 592466
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466
---
 imap-send.c | 2 ++
 1 file changed, 2 insertions(+)

Show changes to imap-send.c +2 −0

diff --git a/imap-send.c b/imap-send.c
index 5c7e27a89..98774360e 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve
 	int ret;
 	X509 *cert;
 
+#if OPENSSL_VERSION_NUMBER < 0x10100000L
 	SSL_library_init();
 	SSL_load_error_strings();
+#endif
 
 	meth = SSLv23_method();
 	if (!meth) {

-- 
2.11.0

Jack Bates· Jan 12, 2017, 16:53 UTC · re: eroen · lore

Re: [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API

You might need the following, to still build with LibreSSL. That was my experience anyway, when I recently prepared similar fixes for OpenSSL 1.1 and Apache Traffic Server.

#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)

On 12/01/17 03:42 AM, eroen wrote:

Show 30 quoted lines

> Library initialization functions are deprecated in openssl 1.1.0 API, as
> initialization is handled by openssl internally.
>
> Symbols for deprecated functions are not exported if openssl is built with
> `--api=1.1 disable-deprecated`, so their use will cause a build failure.
>
> Reported-by: Lars Wendler (Polynomial-C)
>
> X-Gentoo-Bug: 592466
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466
> ---
>  imap-send.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/imap-send.c b/imap-send.c
> index 5c7e27a89..98774360e 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve
>  	int ret;
>  	X509 *cert;
>
> +#if OPENSSL_VERSION_NUMBER < 0x10100000L
>  	SSL_library_init();
>  	SSL_load_error_strings();
> +#endif
>
>  	meth = SSLv23_method();
>  	if (!meth) {
>

Jack Bates· Jan 12, 2017, 16:55 UTC · re: eroen · lore

Re: [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API

You might need the following, to still build with LibreSSL. That was my experience anyway, when I recently prepared similar fixes for OpenSSL 1.1 and Apache Traffic Server.

#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)

On 12/01/17 03:42 AM, eroen wrote:

Show 30 quoted lines

> Library initialization functions are deprecated in openssl 1.1.0 API, as
> initialization is handled by openssl internally.
>
> Symbols for deprecated functions are not exported if openssl is built with
> `--api=1.1 disable-deprecated`, so their use will cause a build failure.
>
> Reported-by: Lars Wendler (Polynomial-C)
>
> X-Gentoo-Bug: 592466
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466
> ---
>  imap-send.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/imap-send.c b/imap-send.c
> index 5c7e27a89..98774360e 100644
> --- a/imap-send.c
> +++ b/imap-send.c
> @@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve
>  	int ret;
>  	X509 *cert;
>
> +#if OPENSSL_VERSION_NUMBER < 0x10100000L
>  	SSL_library_init();
>  	SSL_load_error_strings();
> +#endif
>
>  	meth = SSLv23_method();
>  	if (!meth) {
>