{"thread":{"id":"44861","subject":"[PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API","startedAt":"2017-01-12T10:51:03Z","lastAt":"2017-01-12T16:56:51Z","messageCount":3,"participants":["eroen","Jack Bates"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"309267","messageId":"20170112104219.563497-1-git-scm@occam.eroen.eu","threadId":"44861","inReplyTo":null,"subject":"[PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API","fromName":"eroen","fromEmail":"git-scm@occam.eroen.eu","sentAt":"2017-01-12T10:42:19Z","receivedAt":"2017-01-12T10:51:03Z","isPatch":true,"sender":{"key":"git-scm@occam.eroen.eu","avatar":null},"body":"Library initialization functions are deprecated in openssl 1.1.0 API, as\ninitialization is handled by openssl internally.\n\nSymbols for deprecated functions are not exported if openssl is built with\n`--api=1.1 disable-deprecated`, so their use will cause a build failure.\n\nReported-by: Lars Wendler (Polynomial-C)\n\nX-Gentoo-Bug: 592466\nX-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466\n---\n imap-send.c | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/imap-send.c b/imap-send.c\nindex 5c7e27a89..98774360e 100644\n--- a/imap-send.c\n+++ b/imap-send.c\n@@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve\n \tint ret;\n \tX509 *cert;\n \n+#if OPENSSL_VERSION_NUMBER < 0x10100000L\n \tSSL_library_init();\n \tSSL_load_error_strings();\n+#endif\n \n \tmeth = SSLv23_method();\n \tif (!meth) {\n-- \n2.11.0\n\n"},{"id":"309274","messageId":"27751523-bcc3-4f4b-c833-fc5113af356d@nottheoilrig.com","threadId":"44861","inReplyTo":"20170112104219.563497-1-git-scm@occam.eroen.eu","subject":"Re: [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API","fromName":"Jack Bates","fromEmail":"bk874k@nottheoilrig.com","sentAt":"2017-01-12T16:53:54Z","receivedAt":"2017-01-12T16:54:49Z","isPatch":true,"sender":{"key":"bk874k@nottheoilrig.com","avatar":null},"body":"You might need the following, to still build with LibreSSL.\nThat was my experience anyway, when I recently prepared similar fixes \nfor OpenSSL 1.1 and Apache Traffic Server.\n\n#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)\n\nOn 12/01/17 03:42 AM, eroen wrote:\n> Library initialization functions are deprecated in openssl 1.1.0 API, as\n> initialization is handled by openssl internally.\n>\n> Symbols for deprecated functions are not exported if openssl is built with\n> `--api=1.1 disable-deprecated`, so their use will cause a build failure.\n>\n> Reported-by: Lars Wendler (Polynomial-C)\n>\n> X-Gentoo-Bug: 592466\n> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466\n> ---\n>  imap-send.c | 2 ++\n>  1 file changed, 2 insertions(+)\n>\n> diff --git a/imap-send.c b/imap-send.c\n> index 5c7e27a89..98774360e 100644\n> --- a/imap-send.c\n> +++ b/imap-send.c\n> @@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve\n>  \tint ret;\n>  \tX509 *cert;\n>\n> +#if OPENSSL_VERSION_NUMBER < 0x10100000L\n>  \tSSL_library_init();\n>  \tSSL_load_error_strings();\n> +#endif\n>\n>  \tmeth = SSLv23_method();\n>  \tif (!meth) {\n>\n"},{"id":"309275","messageId":"66967e0e-8bd9-f4b6-d2d4-ccce9004f42e@nottheoilrig.com","threadId":"44861","inReplyTo":"20170112104219.563497-1-git-scm@occam.eroen.eu","subject":"Re: [PATCH] imap-send.c: Avoid deprecated openssl 1.1.0 API","fromName":"Jack Bates","fromEmail":"bk874k@nottheoilrig.com","sentAt":"2017-01-12T16:55:02Z","receivedAt":"2017-01-12T16:56:51Z","isPatch":true,"sender":{"key":"bk874k@nottheoilrig.com","avatar":null},"body":"You might need the following, to still build with LibreSSL.\nThat was my experience anyway, when I recently prepared similar fixes \nfor OpenSSL 1.1 and Apache Traffic Server.\n\n#if OPENSSL_VERSION_NUMBER < 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)\n\nOn 12/01/17 03:42 AM, eroen wrote:\n> Library initialization functions are deprecated in openssl 1.1.0 API, as\n> initialization is handled by openssl internally.\n>\n> Symbols for deprecated functions are not exported if openssl is built with\n> `--api=1.1 disable-deprecated`, so their use will cause a build failure.\n>\n> Reported-by: Lars Wendler (Polynomial-C)\n>\n> X-Gentoo-Bug: 592466\n> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=592466\n> ---\n>  imap-send.c | 2 ++\n>  1 file changed, 2 insertions(+)\n>\n> diff --git a/imap-send.c b/imap-send.c\n> index 5c7e27a89..98774360e 100644\n> --- a/imap-send.c\n> +++ b/imap-send.c\n> @@ -284,8 +284,10 @@ static int ssl_socket_connect(struct imap_socket *sock, int use_tls_only, int ve\n>  \tint ret;\n>  \tX509 *cert;\n>\n> +#if OPENSSL_VERSION_NUMBER < 0x10100000L\n>  \tSSL_library_init();\n>  \tSSL_load_error_strings();\n> +#endif\n>\n>  \tmeth = SSLv23_method();\n>  \tif (!meth) {\n>\n"}]}