threads / bug / 43828

A bug or a feature (git diff --author + --grep)

Subject: A bug or a feature (git diff --author + --grep)

## tl;dr

3 messages between Oct 4, 2009 and Oct 4, 2009.

replies: 2people: 2as markdown or json

Pascal Obry· Oct 4, 2009, 10:25 UTC · lore

I would have expected the --author and --grep option to work as pipeline filters. The first on the command line being applied first.

In other word I would have expected:

    --author AND --grep

But it turn out that the result are maching either --author or --grep:

    --author OR --grep

For example on the Git project:

    $ git log --author=obry --grep=Cygwin

Returns commit from obry and commit having Cygwin in their log.

Is this a bug or a feature?

Thanks, Pascal.

-- 
--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|    http://www.obry.net  -  http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B

Björn Steinbrink· Oct 4, 2009, 13:19 UTC · re: Pascal Obry · lore

Re: A bug or a feature (git diff --author + --grep)

On 2009.10.04 12:25:59 +0200, Pascal Obry wrote:

Show 19 quoted lines

> 
> I would have expected the --author and --grep option to work as
> pipeline filters. The first on the command line being applied first.
> 
> In other word I would have expected:
> 
>    --author AND --grep
> 
> But it turn out that the result are maching either --author or --grep:
> 
>    --author OR --grep
> 
> For example on the Git project:
> 
>    $ git log --author=obry --grep=Cygwin
> 
> Returns commit from obry and commit having Cygwin in their log.
> 
> Is this a bug or a feature?

Feature. There's --all-match to switch on AND-mode.

Björn

Pascal Obry· Oct 4, 2009, 13:44 UTC · re: Björn Steinbrink · lore

Re: A bug or a feature (git diff --author + --grep)

Björn,

> Feature. There's --all-match to switch on AND-mode.

Thanks for the quick answer, I missed the --all-macth option.

-- 
--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|    http://www.obry.net  -  http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B