# A bug or a feature (git diff --author + --grep)

3 messages from 2009-10-04 to 2009-10-04. Participants: Pascal Obry, Björn Steinbrink.
Thread: https://gitlist.dev/t/43828

## Pascal Obry, 2009-10-04 10:25

Subject: A bug or a feature (git diff --author + --grep)
Message-ID: <4AC87837.2010004@obry.net>
URL: https://gitlist.dev/e/4AC87837.2010004%40obry.net

```

I would have expected the --author and --grep option to work as pipeline 
filters. The first on the command line being applied first.

In other word I would have expected:

    --author AND --grep

But it turn out that the result are maching either --author or --grep:

    --author OR --grep

For example on the Git project:

    $ git log --author=obry --grep=Cygwin

Returns commit from obry and commit having Cygwin in their log.

Is this a bug or a feature?

Thanks,
Pascal.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|    http://www.obry.net  -  http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B


```

## Björn Steinbrink, 2009-10-04 13:19

Subject: Re: A bug or a feature (git diff --author + --grep)
Message-ID: <20091004131933.GA32000@atjola.homenet>
URL: https://gitlist.dev/e/20091004131933.GA32000%40atjola.homenet
In-Reply-To: <4AC87837.2010004@obry.net>

```
On 2009.10.04 12:25:59 +0200, Pascal Obry wrote:
> 
> I would have expected the --author and --grep option to work as
> pipeline filters. The first on the command line being applied first.
> 
> In other word I would have expected:
> 
>    --author AND --grep
> 
> But it turn out that the result are maching either --author or --grep:
> 
>    --author OR --grep
> 
> For example on the Git project:
> 
>    $ git log --author=obry --grep=Cygwin
> 
> Returns commit from obry and commit having Cygwin in their log.
> 
> Is this a bug or a feature?

Feature. There's --all-match to switch on AND-mode.

Björn

```

## Pascal Obry, 2009-10-04 13:44

Subject: Re: A bug or a feature (git diff --author + --grep)
Message-ID: <4AC8A6C1.9060905@obry.net>
URL: https://gitlist.dev/e/4AC8A6C1.9060905%40obry.net
In-Reply-To: <20091004131933.GA32000@atjola.homenet>

```
Björn,

> Feature. There's --all-match to switch on AND-mode.

Thanks for the quick answer, I missed the --all-macth option.

-- 

--|------------------------------------------------------
--| Pascal Obry                           Team-Ada Member
--| 45, rue Gabriel Peri - 78114 Magny Les Hameaux FRANCE
--|------------------------------------------------------
--|    http://www.obry.net  -  http://v2p.fr.eu.org
--| "The best way to travel is by means of imagination"
--|
--| gpg --keyserver keys.gnupg.net --recv-key F949BD3B


```