threads / discuss / 43527

Re: unmark after committing with git.el

Subject: Re: unmark after committing with git.el

## tl;dr

4 messages between Dec 6, 2006 and Dec 6, 2006.

replies: 3people: 3as markdown or json

Han-Wen Nienhuys· Dec 6, 2006, 12:43 UTC · lore

unmark after committing with git.el

Hi,

in the usual workflow, I mark a few files, and then commit, and then mark another few for commit.

This patch removes the need to unmark between commits.

From ad694b33e033e3638043cd2d2970e6248beecb91 Mon Sep 17 00:00:00 2001
From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Date: Wed, 6 Dec 2006 13:41:09 +0100
Subject: [PATCH] git.el: unmark files in after committing.

Signed-off-by: Han-Wen Nienhuys <hanwen@xs4all.nl>
---
 contrib/emacs/git.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
index 972c402..642f7bb 100644
--- a/contrib/emacs/git.el
+++ b/contrib/emacs/git.el
@@ -596,7 +596,8 @@ and returns the process output as a string."
                               (git-run-command nil nil "rerere"))
                             (git-refresh-files)
                             (git-refresh-ewoc-hf git-status)
-                            (message "Committed %s." commit))
+                            (message "Committed %s." commit)
+			    (git-unmark-all))
                         (message "Commit aborted."))))
                 (message "No files to commit.")))
           (delete-file index-file))))))

-- 
1.4.4.1.gc9922-dirty


-- 
 Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

Jakub Narebski· Dec 6, 2006, 12:58 UTC · re: Han-Wen Nienhuys · lore

Han-Wen Nienhuys wrote:

> in the usual workflow, I mark a few files, and then commit, and then
> mark another few for commit.
> 
> This patch removes the need to unmark between commits.

This should be in commit message.

Show 8 quoted lines

> 
> From ad694b33e033e3638043cd2d2970e6248beecb91 Mon Sep 17 00:00:00 2001
> From: Han-Wen Nienhuys <hanwen@xs4all.nl>
> Date: Wed, 6 Dec 2006 13:41:09 +0100
> Subject: [PATCH] git.el: unmark files in after committing.
> 
> 
> Signed-off-by: Han-Wen Nienhuys <hanwen@xs4all.nl>

But this break I think PCL-CVS behaviour compatibility. By the way, [Backspace] should unmark all files.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git

Han-Wen Nienhuys· Dec 6, 2006, 13:09 UTC · re: Jakub Narebski · lore

Jakub Narebski escreveu:

> But this break I think PCL-CVS behaviour compatibility. By the way,
> [Backspace] should unmark all files.

it's M-DEL.

Is complete PCL-CVS compatibility a target?

From 62a005d36f97e9950c37a59ee5c976567d702d7a Mon Sep 17 00:00:00 2001
From: Han-Wen Nienhuys <hanwen@xs4all.nl>
Date: Wed, 6 Dec 2006 13:41:09 +0100
Subject: [PATCH] git.el: unmark files in after committing.

In the usual workflow, I mark a few files, and then commit, and then mark another few for commit.

This patch removes the need to unmark between commits.

Signed-off-by: Han-Wen Nienhuys <hanwen@xs4all.nl>
---
 contrib/emacs/git.el |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
index 972c402..642f7bb 100644
--- a/contrib/emacs/git.el
+++ b/contrib/emacs/git.el
@@ -596,7 +596,8 @@ and returns the process output as a string."
                               (git-run-command nil nil "rerere"))
                             (git-refresh-files)
                             (git-refresh-ewoc-hf git-status)
-                            (message "Committed %s." commit))
+                            (message "Committed %s." commit)
+			    (git-unmark-all))
                         (message "Commit aborted."))))
                 (message "No files to commit.")))
           (delete-file index-file))))))

-- 
1.4.4.1.gc9922-dirty




-- 
 Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen

Alexandre Julliard· Dec 6, 2006, 14:24 UTC · re: Han-Wen Nienhuys · lore

Han-Wen Nienhuys <hanwen@xs4all.nl> writes:

Show 7 quoted lines

> Jakub Narebski escreveu:
>> But this break I think PCL-CVS behaviour compatibility. By the way,
>> [Backspace] should unmark all files.
>
> it's M-DEL.
>
> Is complete PCL-CVS compatibility a target?

As far as possible, yes. Note that you don't need to unmark the files to do the next commit, the files you just committed should be in the up-to-date state, and those are ignored when committing (and in most other operations too).

-- 
Alexandre Julliard