{"thread":{"id":"43527","subject":"Re: unmark after committing with git.el","startedAt":"2006-12-06T12:43:55Z","lastAt":"2006-12-06T14:24:27Z","messageCount":4,"participants":["Alexandre Julliard","Han-Wen Nienhuys","Jakub Narebski"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"298450","messageId":"4576BB0B.9010200@xs4all.nl","threadId":"43527","inReplyTo":null,"subject":"unmark after committing with git.el","fromName":"Han-Wen Nienhuys","fromEmail":"hanwen@xs4all.nl","sentAt":"2006-12-06T12:43:55Z","receivedAt":"2006-12-06T12:43:55Z","isPatch":false,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"\nHi,\n\nin the usual workflow, I mark a few files, and then commit, and then\nmark another few for commit.\n\nThis patch removes the need to unmark between commits. \n\n\nFrom ad694b33e033e3638043cd2d2970e6248beecb91 Mon Sep 17 00:00:00 2001\nFrom: Han-Wen Nienhuys <hanwen@xs4all.nl>\nDate: Wed, 6 Dec 2006 13:41:09 +0100\nSubject: [PATCH] git.el: unmark files in after committing.\n\n\nSigned-off-by: Han-Wen Nienhuys <hanwen@xs4all.nl>\n---\n contrib/emacs/git.el |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\nindex 972c402..642f7bb 100644\n--- a/contrib/emacs/git.el\n+++ b/contrib/emacs/git.el\n@@ -596,7 +596,8 @@ and returns the process output as a string.\"\n                               (git-run-command nil nil \"rerere\"))\n                             (git-refresh-files)\n                             (git-refresh-ewoc-hf git-status)\n-                            (message \"Committed %s.\" commit))\n+                            (message \"Committed %s.\" commit)\n+\t\t\t    (git-unmark-all))\n                         (message \"Commit aborted.\"))))\n                 (message \"No files to commit.\")))\n           (delete-file index-file))))))\n-- \n1.4.4.1.gc9922-dirty\n\n\n-- \n Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen\n"},{"id":"297261","messageId":"el6eku$vg7$3@sea.gmane.org","threadId":"43527","inReplyTo":"4576BB0B.9010200@xs4all.nl","subject":"Re: unmark after committing with git.el","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2006-12-06T12:58:06Z","receivedAt":"2006-12-06T12:58:06Z","isPatch":false,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Han-Wen Nienhuys wrote:\n\n> in the usual workflow, I mark a few files, and then commit, and then\n> mark another few for commit.\n> \n> This patch removes the need to unmark between commits. \n\nThis should be in commit message.\n \n> \n> From ad694b33e033e3638043cd2d2970e6248beecb91 Mon Sep 17 00:00:00 2001\n> From: Han-Wen Nienhuys <hanwen@xs4all.nl>\n> Date: Wed, 6 Dec 2006 13:41:09 +0100\n> Subject: [PATCH] git.el: unmark files in after committing.\n> \n> \n> Signed-off-by: Han-Wen Nienhuys <hanwen@xs4all.nl>\n\nBut this break I think PCL-CVS behaviour compatibility. By the way,\n[Backspace] should unmark all files.\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n\n"},{"id":"295309","messageId":"4576C0FB.8060000@xs4all.nl","threadId":"43527","inReplyTo":"el6eku$vg7$3@sea.gmane.org","subject":"Re: unmark after committing with git.el","fromName":"Han-Wen Nienhuys","fromEmail":"hanwen@xs4all.nl","sentAt":"2006-12-06T13:09:15Z","receivedAt":"2006-12-06T13:09:15Z","isPatch":false,"sender":{"key":"hanwen@google.com","avatar":"https://avatars.githubusercontent.com/u/31547?v=4"},"body":"Jakub Narebski escreveu:\n> But this break I think PCL-CVS behaviour compatibility. By the way,\n> [Backspace] should unmark all files.\n\nit's M-DEL.\n\nIs complete PCL-CVS compatibility a target?\n\n\n\n\n\nFrom 62a005d36f97e9950c37a59ee5c976567d702d7a Mon Sep 17 00:00:00 2001\nFrom: Han-Wen Nienhuys <hanwen@xs4all.nl>\nDate: Wed, 6 Dec 2006 13:41:09 +0100\nSubject: [PATCH] git.el: unmark files in after committing.\n\nIn the usual workflow, I mark a few files, and then commit, and then\nmark another few for commit.\n\nThis patch removes the need to unmark between commits.\n\nSigned-off-by: Han-Wen Nienhuys <hanwen@xs4all.nl>\n---\n contrib/emacs/git.el |    3 ++-\n 1 files changed, 2 insertions(+), 1 deletions(-)\n\ndiff --git a/contrib/emacs/git.el b/contrib/emacs/git.el\nindex 972c402..642f7bb 100644\n--- a/contrib/emacs/git.el\n+++ b/contrib/emacs/git.el\n@@ -596,7 +596,8 @@ and returns the process output as a string.\"\n                               (git-run-command nil nil \"rerere\"))\n                             (git-refresh-files)\n                             (git-refresh-ewoc-hf git-status)\n-                            (message \"Committed %s.\" commit))\n+                            (message \"Committed %s.\" commit)\n+\t\t\t    (git-unmark-all))\n                         (message \"Commit aborted.\"))))\n                 (message \"No files to commit.\")))\n           (delete-file index-file))))))\n-- \n1.4.4.1.gc9922-dirty\n\n\n\n\n-- \n Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen\n"},{"id":"295288","messageId":"87irgp85lw.fsf@wine.dyndns.org","threadId":"43527","inReplyTo":"4576C0FB.8060000@xs4all.nl","subject":"Re: unmark after committing with git.el","fromName":"Alexandre Julliard","fromEmail":"julliard@winehq.org","sentAt":"2006-12-06T14:24:27Z","receivedAt":"2006-12-06T14:24:27Z","isPatch":false,"sender":{"key":"julliard@winehq.org","avatar":null},"body":"Han-Wen Nienhuys <hanwen@xs4all.nl> writes:\n\n> Jakub Narebski escreveu:\n>> But this break I think PCL-CVS behaviour compatibility. By the way,\n>> [Backspace] should unmark all files.\n>\n> it's M-DEL.\n>\n> Is complete PCL-CVS compatibility a target?\n\nAs far as possible, yes. Note that you don't need to unmark the files\nto do the next commit, the files you just committed should be in the\nup-to-date state, and those are ignored when committing (and in most\nother operations too).\n\n-- \nAlexandre Julliard\n"}]}