threads / patch / 42786

patchhttp-walker: remove unused parameter from fetch_object

Subject: [PATCH] http-walker: remove unused parameter from fetch_object

## tl;dr

One message between Jul 6, 2016 and Jul 6, 2016. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Eric Wong· Jul 6, 2016, 01:57 UTC · lore

This parameter has not been used since commit 1d389ab65dc6 ("Add support for parallel HTTP transfers") back in 2005

Signed-off-by: Eric Wong <e@80x24.org>
---
 I might followup in a few days/weeks with further updates in
 this area, but at least should be trivially correct :)
 http-walker.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Show changes to http-walker.c +2 −2
diff --git a/http-walker.c b/http-walker.c
index 2c721f0..9f28523 100644
--- a/http-walker.c
+++ b/http-walker.c
@@ -447,7 +447,7 @@ static void abort_object_request(struct object_request *obj_req)
 	release_object_request(obj_req);
 }
 
-static int fetch_object(struct walker *walker, struct alt_base *repo, unsigned char *sha1)
+static int fetch_object(struct walker *walker, unsigned char *sha1)
 {
 	char *hex = sha1_to_hex(sha1);
 	int ret = 0;
@@ -518,7 +518,7 @@ static int fetch(struct walker *walker, unsigned char *sha1)
 	struct walker_data *data = walker->data;
 	struct alt_base *altbase = data->alt;
 
-	if (!fetch_object(walker, altbase, sha1))
+	if (!fetch_object(walker, sha1))
 		return 0;
 	while (altbase) {
 		if (!http_fetch_pack(walker, altbase, sha1))
-- 
EW

← back to recent threads