{"thread":{"id":"42786","subject":"[PATCH] http-walker: remove unused parameter from fetch_object","startedAt":"2016-07-06T01:57:17Z","lastAt":"2016-07-06T01:57:17Z","messageCount":1,"participants":["Eric Wong"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"290867","messageId":"20160706015708.GA18690@dcvr.yhbt.net","threadId":"42786","inReplyTo":null,"subject":"[PATCH] http-walker: remove unused parameter from fetch_object","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2016-07-06T01:57:08Z","receivedAt":"2016-07-06T01:57:17Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"This parameter has not been used since commit 1d389ab65dc6\n(\"Add support for parallel HTTP transfers\") back in 2005\n\nSigned-off-by: Eric Wong <e@80x24.org>\n---\n I might followup in a few days/weeks with further updates in\n this area, but at least should be trivially correct :)\n\n http-walker.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/http-walker.c b/http-walker.c\nindex 2c721f0..9f28523 100644\n--- a/http-walker.c\n+++ b/http-walker.c\n@@ -447,7 +447,7 @@ static void abort_object_request(struct object_request *obj_req)\n \trelease_object_request(obj_req);\n }\n \n-static int fetch_object(struct walker *walker, struct alt_base *repo, unsigned char *sha1)\n+static int fetch_object(struct walker *walker, unsigned char *sha1)\n {\n \tchar *hex = sha1_to_hex(sha1);\n \tint ret = 0;\n@@ -518,7 +518,7 @@ static int fetch(struct walker *walker, unsigned char *sha1)\n \tstruct walker_data *data = walker->data;\n \tstruct alt_base *altbase = data->alt;\n \n-\tif (!fetch_object(walker, altbase, sha1))\n+\tif (!fetch_object(walker, sha1))\n \t\treturn 0;\n \twhile (altbase) {\n \t\tif (!http_fetch_pack(walker, altbase, sha1))\n-- \nEW\n"}]}