threads / patch / 42585

patchDocument the 'svn propset' command.

Subject: [PATCH] Document the 'svn propset' command.

## tl;dr

11 messages between Jun 16, 2016 and Jun 16, 2016. Diffs are folded; open one to read it.

replies: 10people: 5as markdown or json

Alfred Perlstein· Jun 12, 2016, 19:15 UTC · lore
Junio + all,

A week ago I was requested to provide documentation for the 'svn propset' command. I have attached a diff off of the 'maint' branch for this, however it seems to apply cleanly to 'master' as well.

Thank you for your patience.

This is also available on my github here: https://github.com/splbio/git/tree/document_propset

---
 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Show changes to Documentation/git-svn.txt +14 −0
diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
index fb23a98..e104824 100644
--- a/Documentation/git-svn.txt
+++ b/Documentation/git-svn.txt
@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
 	Gets the Subversion property given as the first argument, for a
 	file.  A specific revision can be specified with -r/--revision.
 
+'propset'::
+	Sets the Subversion property given as the first argument, to the
+	value given as the second argument for the file given as the
+	third argument.
++
+Example:
++
+------------------------------------------------------------------------
+git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
+------------------------------------------------------------------------
++
+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
+'devel/py-tipper/Makefile'.
+
 'show-externals'::
 	Shows the Subversion externals.  Use -r/--revision to specify a
 	specific revision.
-- 
2.7.1
Pranit Bauva· Jun 13, 2016, 06:59 UTC · re: Alfred Perlstein · lore

Re: [PATCH] Document the 'svn propset' command.

Hey Alfred,
On Mon, Jun 13, 2016 at 12:45 AM, Alfred Perlstein <alfred@freebsd.org> wrote:
Show 11 quoted lines
> Junio + all,
>
> A week ago I was requested to provide documentation for the
> 'svn propset' command.  I have attached a diff off of the
> 'maint' branch for this, however it seems to apply cleanly
> to 'master' as well.
>
> Thank you for your patience.
>
> This is also available on my github here:
> https://github.com/splbio/git/tree/document_propset

I am not particularly sure whether the above could form a good commit message. I think you wanted to include this as a comment. git-am picks up these patches. The title commit is taken from the subject stripping the '[PATCH]'. Then the body before '---' is taken as the rest of the commit message. Then the diff is applied. To include comments add them after ---. Also please have a look at Documentation/SubmittingPatches. Also missing signoff. For the patch to actually be accept you need to follow those instructions. Thanks for contributing.

Show 29 quoted lines
> ---
>  Documentation/git-svn.txt | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
> index fb23a98..e104824 100644
> --- a/Documentation/git-svn.txt
> +++ b/Documentation/git-svn.txt
> @@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
>         Gets the Subversion property given as the first argument, for a
>         file.  A specific revision can be specified with -r/--revision.
>
> +'propset'::
> +       Sets the Subversion property given as the first argument, to the
> +       value given as the second argument for the file given as the
> +       third argument.
> ++
> +Example:
> ++
> +------------------------------------------------------------------------
> +git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
> +------------------------------------------------------------------------
> ++
> +This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
> +'devel/py-tipper/Makefile'.
> +
>  'show-externals'::
>         Shows the Subversion externals.  Use -r/--revision to specify a
>         specific revision.

Regards, Pranit Bauva

Alfred Perlstein· Jun 13, 2016, 12:52 UTC · re: Pranit Bauva · lore

Re: [PATCH] Document the 'svn propset' command.

Thank you Pranit. I thought that "signed off by" is used once someone approved my patch as opposed to when it's in "proposal" stage. This was my first email with a patch for this issue, who should/could I have used for "signoff"?

-Alfred
On 6/12/16 11:59 PM, Pranit Bauva wrote:
Show 55 quoted lines
> Hey Alfred,
>
> On Mon, Jun 13, 2016 at 12:45 AM, Alfred Perlstein <alfred@freebsd.org> wrote:
>> Junio + all,
>>
>> A week ago I was requested to provide documentation for the
>> 'svn propset' command.  I have attached a diff off of the
>> 'maint' branch for this, however it seems to apply cleanly
>> to 'master' as well.
>>
>> Thank you for your patience.
>>
>> This is also available on my github here:
>> https://github.com/splbio/git/tree/document_propset
> I am not particularly sure whether the above could form a good commit
> message. I think you wanted to include this as a comment. git-am picks
> up these patches. The title commit is taken from the subject stripping
> the '[PATCH]'. Then the body before '---' is taken as the rest of the
> commit message. Then the diff is applied. To include comments add them
> after ---. Also please have a look at Documentation/SubmittingPatches.
> Also missing signoff. For the patch to actually be accept you need to
> follow those instructions. Thanks for contributing.
>
>> ---
>>   Documentation/git-svn.txt | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
>> index fb23a98..e104824 100644
>> --- a/Documentation/git-svn.txt
>> +++ b/Documentation/git-svn.txt
>> @@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
>>          Gets the Subversion property given as the first argument, for a
>>          file.  A specific revision can be specified with -r/--revision.
>>
>> +'propset'::
>> +       Sets the Subversion property given as the first argument, to the
>> +       value given as the second argument for the file given as the
>> +       third argument.
>> ++
>> +Example:
>> ++
>> +------------------------------------------------------------------------
>> +git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
>> +------------------------------------------------------------------------
>> ++
>> +This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
>> +'devel/py-tipper/Makefile'.
>> +
>>   'show-externals'::
>>          Shows the Subversion externals.  Use -r/--revision to specify a
>>          specific revision.
> Regards,
> Pranit Bauva
>
Pranit Bauva· Jun 13, 2016, 14:24 UTC · re: Alfred Perlstein · lore

Re: [PATCH] Document the 'svn propset' command.

Hey Alfred,
On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
> Thank you Pranit.  I thought that "signed off by" is used once someone
> approved my patch as opposed to when it's in "proposal" stage.  This was my
> first email with a patch for this issue, who should/could I have used for
> "signoff"?

Signoff is used to indicate that you are OKAY with releasing your patch according to git's license. For more details see the Documentation/SubmittingPatches[1]. To summarize you will have to add this in the end :

   Signed-off-by: Alfred Perlstein <alfred@freebsd.org>
Though I will still recommend you to go through [1] properly.

Regards, Pranit Bauva

Pranit Bauva· Jun 13, 2016, 14:42 UTC · re: Pranit Bauva · lore

Re: [PATCH] Document the 'svn propset' command.

Hey Alfred,
On Mon, Jun 13, 2016 at 7:54 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
Show 16 quoted lines
> Hey Alfred,
>
> On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
>> Thank you Pranit.  I thought that "signed off by" is used once someone
>> approved my patch as opposed to when it's in "proposal" stage.  This was my
>> first email with a patch for this issue, who should/could I have used for
>> "signoff"?
>
> Signoff is used to indicate that you are OKAY with releasing your
> patch according to git's license. For more details see the
> Documentation/SubmittingPatches[1]. To summarize you will have to add
> this in the end :
>
>    Signed-off-by: Alfred Perlstein <alfred@freebsd.org>
>
> Though I will still recommend you to go through [1] properly.
Oops I forgot to put the link.
[1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L239-L307

Regards, Pranit Bauva

Alfred Perlstein· Jun 13, 2016, 22:09 UTC · re: Pranit Bauva · lore

Re: [PATCH] Document the 'svn propset' command.

On 6/13/16 7:42 AM, Pranit Bauva wrote:
Show 22 quoted lines
> Hey Alfred,
>
> On Mon, Jun 13, 2016 at 7:54 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
>> Hey Alfred,
>>
>> On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
>>> Thank you Pranit.  I thought that "signed off by" is used once someone
>>> approved my patch as opposed to when it's in "proposal" stage.  This was my
>>> first email with a patch for this issue, who should/could I have used for
>>> "signoff"?
>> Signoff is used to indicate that you are OKAY with releasing your
>> patch according to git's license. For more details see the
>> Documentation/SubmittingPatches[1]. To summarize you will have to add
>> this in the end :
>>
>>     Signed-off-by: Alfred Perlstein <alfred@freebsd.org>
>>
>> Though I will still recommend you to go through [1] properly.
> Oops I forgot to put the link.
>
> [1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L239-L307
>
Pranit,
Ah thank you!!!  This clarifies.  I will resend the patch tonight.
-Alfred
Alfred Perlstein· Jun 15, 2016, 05:19 UTC · re: Alfred Perlstein · lore
Add example usage to the git-svn documentation.
Reported-by: Joseph Pecoraro <pecoraro@apple.com>
Signed-off-by: Alfred Perlstein <alfred@freebsd.org> 
---
Junio, Pranit, + all,

A week ago I was requested to provide documentation for the 'svn propset' command. I have attached a diff off of the 'maint' branch for this, however it seems to apply cleanly to 'master' as well.

Thank you for your patience.

This is also available on my github here: https://github.com/splbio/git/tree/document_propset

 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Show changes to Documentation/git-svn.txt +14 −0
diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
index fb23a98..e104824 100644
--- a/Documentation/git-svn.txt
+++ b/Documentation/git-svn.txt
@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'
 	Gets the Subversion property given as the first argument, for a
 	file.  A specific revision can be specified with -r/--revision.
 
+'propset'::
+	Sets the Subversion property given as the first argument, to the
+	value given as the second argument for the file given as the
+	third argument.
++
+Example:
++
+------------------------------------------------------------------------
+git svn propset svn:keywords "FreeBSD=%H" devel/py-tipper/Makefile
+------------------------------------------------------------------------
++
+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file
+'devel/py-tipper/Makefile'.
+
 'show-externals'::
 	Shows the Subversion externals.  Use -r/--revision to specify a
 	specific revision.
-- 
2.7.1
Eric Wong· Jun 15, 2016, 20:15 UTC · re: Alfred Perlstein · lore

Re: [PATCH] Document the 'svn propset' command.

Alfred Perlstein <alfred@freebsd.org> wrote:
Show 14 quoted lines
> Add example usage to the git-svn documentation.
> 
> Reported-by: Joseph Pecoraro <pecoraro@apple.com>
> Signed-off-by: Alfred Perlstein <alfred@freebsd.org> 
> ---
> 
> Junio, Pranit, + all,
> 
> A week ago I was requested to provide documentation for the
> 'svn propset' command.  I have attached a diff off of the
> 'maint' branch for this, however it seems to apply cleanly
> to 'master' as well.
> 
> Thank you for your patience.
Thanks Alfred,

I've removed the '.' from the commit subject, signed-off, and pushed to my repo for Junio:

The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:
  Git 2.9 (2016-06-13 10:42:13 -0700)
are available in the git repository at:
  git://bogomips.org/git-svn.git svn-propset-doc
for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:
  Document the 'svn propset' command (2016-06-15 20:11:22 +0000)
----------------------------------------------------------------
Alfred Perlstein (1):
      Document the 'svn propset' command
 Documentation/git-svn.txt | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Junio C Hamano· Jun 15, 2016, 20:21 UTC · re: Eric Wong · lore

Re: [PATCH] Document the 'svn propset' command.

Eric Wong <e@80x24.org> writes:
Show 16 quoted lines
> Thanks Alfred,
>
> I've removed the '.' from the commit subject, signed-off,
> and pushed to my repo for Junio:
>
> The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:
>
>   Git 2.9 (2016-06-13 10:42:13 -0700)
>
> are available in the git repository at:
>
>   git://bogomips.org/git-svn.git svn-propset-doc
>
> for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:
>
>   Document the 'svn propset' command (2016-06-15 20:11:22 +0000)

I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn: support for git-svn propset, 2014-12-07) so that it could go to older maintenance tracks.

I will pick up your Reviewed-by: and redo it.  Thanks.
Alfred Perlstein· Jun 15, 2016, 20:24 UTC · re: Junio C Hamano · lore

Re: [PATCH] Document the 'svn propset' command.

Show 27 quoted lines
> On Jun 15, 2016, at 1:21 PM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Eric Wong <e@80x24.org> writes:
> 
>> Thanks Alfred,
>> 
>> I've removed the '.' from the commit subject, signed-off,
>> and pushed to my repo for Junio:
>> 
>> The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:
>> 
>>  Git 2.9 (2016-06-13 10:42:13 -0700)
>> 
>> are available in the git repository at:
>> 
>>  git://bogomips.org/git-svn.git svn-propset-doc
>> 
>> for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:
>> 
>>  Document the 'svn propset' command (2016-06-15 20:11:22 +0000)
> 
> I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:
> support for git-svn propset, 2014-12-07) so that it could go to
> older maintenance tracks.
> 
> I will pick up your Reviewed-by: and redo it.  Thanks.
> 
Thank you, always great working with the git project!  
-Alfred 
Joseph Pecoraro· Jun 15, 2016, 20:32 UTC · re: Alfred Perlstein · lore

Re: [PATCH] Document the 'svn propset' command.

Show 33 quoted lines
> On Jun 15, 2016, at 1:24 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
> 
>> On Jun 15, 2016, at 1:21 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> Eric Wong <e@80x24.org> writes:
>> 
>>> Thanks Alfred,
>>> 
>>> I've removed the '.' from the commit subject, signed-off,
>>> and pushed to my repo for Junio:
>>> 
>>> The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:
>>> 
>>> Git 2.9 (2016-06-13 10:42:13 -0700)
>>> 
>>> are available in the git repository at:
>>> 
>>> git://bogomips.org/git-svn.git svn-propset-doc
>>> 
>>> for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:
>>> 
>>> Document the 'svn propset' command (2016-06-15 20:11:22 +0000)
>> 
>> I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:
>> support for git-svn propset, 2014-12-07) so that it could go to
>> older maintenance tracks.
>> 
>> I will pick up your Reviewed-by: and redo it.  Thanks.
>> 
> 
> Thank you, always great working with the git project!  
> 
> -Alfred 
Thanks for addressing this!
- Joe

← back to recent threads