{"thread":{"id":"42585","subject":"[PATCH] Document the 'svn propset' command.","startedAt":"2016-06-16T02:19:53Z","lastAt":"2016-06-16T06:55:53Z","messageCount":11,"participants":["Alfred Perlstein","Pranit Bauva","Eric Wong","Junio C Hamano","Joseph Pecoraro"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"289060","messageId":"20160612191550.GA14160@elvis.mu.org","threadId":"42585","inReplyTo":null,"subject":"[PATCH] Document the 'svn propset' command.","fromName":"Alfred Perlstein","fromEmail":"alfred@freebsd.org","sentAt":"2016-06-12T19:15:50Z","receivedAt":"2016-06-16T02:19:53Z","isPatch":true,"sender":{"key":"alfred@freebsd.org","avatar":"https://avatars.githubusercontent.com/u/629072?v=4"},"body":"Junio + all,\n\nA week ago I was requested to provide documentation for the\n'svn propset' command. I have attached a diff off of the\n'maint' branch for this, however it seems to apply cleanly\nto 'master' as well.\n\nThank you for your patience.\n\nThis is also available on my github here:\nhttps://github.com/splbio/git/tree/document_propset\n\n\n---\n Documentation/git-svn.txt | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex fb23a98..e104824 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'\n \tGets the Subversion property given as the first argument, for a\n \tfile. A specific revision can be specified with -r/--revision.\n \n+'propset'::\n+\tSets the Subversion property given as the first argument, to the\n+\tvalue given as the second argument for the file given as the\n+\tthird argument.\n++\n+Example:\n++\n+------------------------------------------------------------------------\n+git svn propset svn:keywords \"FreeBSD=%H\" devel/py-tipper/Makefile\n+------------------------------------------------------------------------\n++\n+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file\n+'devel/py-tipper/Makefile'.\n+\n 'show-externals'::\n \tShows the Subversion externals. Use -r/--revision to specify a\n \tspecific revision.\n-- \n2.7.1\n"},{"id":"289082","messageId":"CAFZEwPM5qnzw7RCUwOkJFo+U982kVGU8_3GUTXvHAypKtvEgTQ@mail.gmail.com","threadId":"42585","inReplyTo":"20160612191550.GA14160@elvis.mu.org","subject":"Re: [PATCH] Document the 'svn propset' command.","fromName":"Pranit Bauva","fromEmail":"pranit.bauva@gmail.com","sentAt":"2016-06-13T06:59:08Z","receivedAt":"2016-06-16T02:19:53Z","isPatch":true,"sender":{"key":"pranit.bauva@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2959938?v=4"},"body":"Hey Alfred,\n\nOn Mon, Jun 13, 2016 at 12:45 AM, Alfred Perlstein wrote:\n> Junio + all,\n>\n> A week ago I was requested to provide documentation for the\n> 'svn propset' command. I have attached a diff off of the\n> 'maint' branch for this, however it seems to apply cleanly\n> to 'master' as well.\n>\n> Thank you for your patience.\n>\n> This is also available on my github here:\n> https://github.com/splbio/git/tree/document_propset\n\nI am not particularly sure whether the above could form a good commit\nmessage. I think you wanted to include this as a comment. git-am picks\nup these patches. The title commit is taken from the subject stripping\nthe '[PATCH]'. Then the body before '---' is taken as the rest of the\ncommit message. Then the diff is applied. To include comments add them\nafter ---. Also please have a look at Documentation/SubmittingPatches.\nAlso missing signoff. For the patch to actually be accept you need to\nfollow those instructions. Thanks for contributing.\n\n> ---\n> Documentation/git-svn.txt | 14 ++++++++++++++\n> 1 file changed, 14 insertions(+)\n>\n> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\n> index fb23a98..e104824 100644\n> --- a/Documentation/git-svn.txt\n> +++ b/Documentation/git-svn.txt\n> @@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'\n> Gets the Subversion property given as the first argument, for a\n> file. A specific revision can be specified with -r/--revision.\n>\n> +'propset'::\n> + Sets the Subversion property given as the first argument, to the\n> + value given as the second argument for the file given as the\n> + third argument.\n> ++\n> +Example:\n> ++\n> +------------------------------------------------------------------------\n> +git svn propset svn:keywords \"FreeBSD=%H\" devel/py-tipper/Makefile\n> +------------------------------------------------------------------------\n> ++\n> +This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file\n> +'devel/py-tipper/Makefile'.\n> +\n> 'show-externals'::\n> Shows the Subversion externals. Use -r/--revision to specify a\n> specific revision.\n\nRegards,\nPranit Bauva\n"},{"id":"289111","messageId":"81a197e2-7e0e-176a-c934-0e5f95cfda83@freebsd.org","threadId":"42585","inReplyTo":"CAFZEwPM5qnzw7RCUwOkJFo+U982kVGU8_3GUTXvHAypKtvEgTQ@mail.gmail.com","subject":"Re: [PATCH] Document the 'svn propset' command.","fromName":"Alfred Perlstein","fromEmail":"alfred@freebsd.org","sentAt":"2016-06-13T12:52:12Z","receivedAt":"2016-06-16T02:19:53Z","isPatch":true,"sender":{"key":"alfred@freebsd.org","avatar":"https://avatars.githubusercontent.com/u/629072?v=4"},"body":"Thank you Pranit. I thought that \"signed off by\" is used once someone \napproved my patch as opposed to when it's in \"proposal\" stage. This was \nmy first email with a patch for this issue, who should/could I have used \nfor \"signoff\"?\n\n\n-Alfred\n\n\nOn 6/12/16 11:59 PM, Pranit Bauva wrote:\n> Hey Alfred,\n>\n> On Mon, Jun 13, 2016 at 12:45 AM, Alfred Perlstein wrote:\n>> Junio + all,\n>>\n>> A week ago I was requested to provide documentation for the\n>> 'svn propset' command. I have attached a diff off of the\n>> 'maint' branch for this, however it seems to apply cleanly\n>> to 'master' as well.\n>>\n>> Thank you for your patience.\n>>\n>> This is also available on my github here:\n>> https://github.com/splbio/git/tree/document_propset\n> I am not particularly sure whether the above could form a good commit\n> message. I think you wanted to include this as a comment. git-am picks\n> up these patches. The title commit is taken from the subject stripping\n> the '[PATCH]'. Then the body before '---' is taken as the rest of the\n> commit message. Then the diff is applied. To include comments add them\n> after ---. Also please have a look at Documentation/SubmittingPatches.\n> Also missing signoff. For the patch to actually be accept you need to\n> follow those instructions. Thanks for contributing.\n>\n>> ---\n>> Documentation/git-svn.txt | 14 ++++++++++++++\n>> 1 file changed, 14 insertions(+)\n>>\n>> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\n>> index fb23a98..e104824 100644\n>> --- a/Documentation/git-svn.txt\n>> +++ b/Documentation/git-svn.txt\n>> @@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'\n>> Gets the Subversion property given as the first argument, for a\n>> file. A specific revision can be specified with -r/--revision.\n>>\n>> +'propset'::\n>> + Sets the Subversion property given as the first argument, to the\n>> + value given as the second argument for the file given as the\n>> + third argument.\n>> ++\n>> +Example:\n>> ++\n>> +------------------------------------------------------------------------\n>> +git svn propset svn:keywords \"FreeBSD=%H\" devel/py-tipper/Makefile\n>> +------------------------------------------------------------------------\n>> ++\n>> +This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file\n>> +'devel/py-tipper/Makefile'.\n>> +\n>> 'show-externals'::\n>> Shows the Subversion externals. Use -r/--revision to specify a\n>> specific revision.\n> Regards,\n> Pranit Bauva\n>\n"},{"id":"289112","messageId":"CAFZEwPNGz18uyLT62PsR-ybF32KJPb5PssQXJXuA4eWUFtPXnw@mail.gmail.com","threadId":"42585","inReplyTo":"81a197e2-7e0e-176a-c934-0e5f95cfda83@freebsd.org","subject":"Re: [PATCH] Document the 'svn propset' command.","fromName":"Pranit Bauva","fromEmail":"pranit.bauva@gmail.com","sentAt":"2016-06-13T14:24:32Z","receivedAt":"2016-06-16T02:19:53Z","isPatch":true,"sender":{"key":"pranit.bauva@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2959938?v=4"},"body":"Hey Alfred,\n\nOn Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein wrote:\n> Thank you Pranit. I thought that \"signed off by\" is used once someone\n> approved my patch as opposed to when it's in \"proposal\" stage. This was my\n> first email with a patch for this issue, who should/could I have used for\n> \"signoff\"?\n\nSignoff is used to indicate that you are OKAY with releasing your\npatch according to git's license. For more details see the\nDocumentation/SubmittingPatches[1]. To summarize you will have to add\nthis in the end :\n\n Signed-off-by: Alfred Perlstein \n\nThough I will still recommend you to go through [1] properly.\n\nRegards,\nPranit Bauva\n"},{"id":"289113","messageId":"CAFZEwPO3_gYP1fO1-3S1M0dnSVo1Ji9ALJNTdN-ZrYsNVfX0cg@mail.gmail.com","threadId":"42585","inReplyTo":"CAFZEwPNGz18uyLT62PsR-ybF32KJPb5PssQXJXuA4eWUFtPXnw@mail.gmail.com","subject":"Re: [PATCH] Document the 'svn propset' command.","fromName":"Pranit Bauva","fromEmail":"pranit.bauva@gmail.com","sentAt":"2016-06-13T14:42:04Z","receivedAt":"2016-06-16T02:19:53Z","isPatch":true,"sender":{"key":"pranit.bauva@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2959938?v=4"},"body":"Hey Alfred,\n\nOn Mon, Jun 13, 2016 at 7:54 PM, Pranit Bauva wrote:\n> Hey Alfred,\n>\n> On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein wrote:\n>> Thank you Pranit. I thought that \"signed off by\" is used once someone\n>> approved my patch as opposed to when it's in \"proposal\" stage. This was my\n>> first email with a patch for this issue, who should/could I have used for\n>> \"signoff\"?\n>\n> Signoff is used to indicate that you are OKAY with releasing your\n> patch according to git's license. For more details see the\n> Documentation/SubmittingPatches[1]. To summarize you will have to add\n> this in the end :\n>\n> Signed-off-by: Alfred Perlstein \n>\n> Though I will still recommend you to go through [1] properly.\n\nOops I forgot to put the link.\n\n[1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L239-L307\n\nRegards,\nPranit Bauva\n"},{"id":"289169","messageId":"3ba0c800-6e51-fe80-d73a-f45131f9269c@freebsd.org","threadId":"42585","inReplyTo":"CAFZEwPO3_gYP1fO1-3S1M0dnSVo1Ji9ALJNTdN-ZrYsNVfX0cg@mail.gmail.com","subject":"Re: [PATCH] Document the 'svn propset' command.","fromName":"Alfred Perlstein","fromEmail":"alfred@freebsd.org","sentAt":"2016-06-13T22:09:17Z","receivedAt":"2016-06-16T06:55:52Z","isPatch":true,"sender":{"key":"alfred@freebsd.org","avatar":"https://avatars.githubusercontent.com/u/629072?v=4"},"body":"\n\nOn 6/13/16 7:42 AM, Pranit Bauva wrote:\n> Hey Alfred,\n>\n> On Mon, Jun 13, 2016 at 7:54 PM, Pranit Bauva wrote:\n>> Hey Alfred,\n>>\n>> On Mon, Jun 13, 2016 at 6:22 PM, Alfred Perlstein wrote:\n>>> Thank you Pranit. I thought that \"signed off by\" is used once someone\n>>> approved my patch as opposed to when it's in \"proposal\" stage. This was my\n>>> first email with a patch for this issue, who should/could I have used for\n>>> \"signoff\"?\n>> Signoff is used to indicate that you are OKAY with releasing your\n>> patch according to git's license. For more details see the\n>> Documentation/SubmittingPatches[1]. To summarize you will have to add\n>> this in the end :\n>>\n>> Signed-off-by: Alfred Perlstein \n>>\n>> Though I will still recommend you to go through [1] properly.\n> Oops I forgot to put the link.\n>\n> [1]: https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L239-L307\n>\nPranit,\n\nAh thank you!!! This clarifies. I will resend the patch tonight.\n\n-Alfred\n"},{"id":"289276","messageId":"20160615051950.GA93388@elvis.mu.org","threadId":"42585","inReplyTo":"20160612191550.GA14160@elvis.mu.org","subject":"[PATCH] Document the 'svn propset' command.","fromName":"Alfred Perlstein","fromEmail":"alfred@freebsd.org","sentAt":"2016-06-15T05:19:50Z","receivedAt":"2016-06-16T06:55:53Z","isPatch":true,"sender":{"key":"alfred@freebsd.org","avatar":"https://avatars.githubusercontent.com/u/629072?v=4"},"body":"Add example usage to the git-svn documentation.\n\nReported-by: Joseph Pecoraro \nSigned-off-by: Alfred Perlstein \n---\n\nJunio, Pranit, + all,\n\nA week ago I was requested to provide documentation for the\n'svn propset' command. I have attached a diff off of the\n'maint' branch for this, however it seems to apply cleanly\nto 'master' as well.\n\nThank you for your patience.\n\nThis is also available on my github here:\nhttps://github.com/splbio/git/tree/document_propset\n\n\n\n Documentation/git-svn.txt | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)\n\ndiff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt\nindex fb23a98..e104824 100644\n--- a/Documentation/git-svn.txt\n+++ b/Documentation/git-svn.txt\n@@ -459,6 +459,20 @@ Any other arguments are passed directly to 'git log'\n \tGets the Subversion property given as the first argument, for a\n \tfile. A specific revision can be specified with -r/--revision.\n \n+'propset'::\n+\tSets the Subversion property given as the first argument, to the\n+\tvalue given as the second argument for the file given as the\n+\tthird argument.\n++\n+Example:\n++\n+------------------------------------------------------------------------\n+git svn propset svn:keywords \"FreeBSD=%H\" devel/py-tipper/Makefile\n+------------------------------------------------------------------------\n++\n+This will set the property 'svn:keywords' to 'FreeBSD=%H' for the file\n+'devel/py-tipper/Makefile'.\n+\n 'show-externals'::\n \tShows the Subversion externals. Use -r/--revision to specify a\n \tspecific revision.\n-- \n2.7.1\n"},{"id":"289317","messageId":"20160615201556.GA6303@dcvr.yhbt.net","threadId":"42585","inReplyTo":"20160615051950.GA93388@elvis.mu.org","subject":"Re: [PATCH] Document the 'svn propset' command.","fromName":"Eric Wong","fromEmail":"e@80x24.org","sentAt":"2016-06-15T20:15:56Z","receivedAt":"2016-06-16T06:55:53Z","isPatch":true,"sender":{"key":"e@80x24.org","avatar":null},"body":"Alfred Perlstein wrote:\n> Add example usage to the git-svn documentation.\n> \n> Reported-by: Joseph Pecoraro \n> Signed-off-by: Alfred Perlstein \n> ---\n> \n> Junio, Pranit, + all,\n> \n> A week ago I was requested to provide documentation for the\n> 'svn propset' command. I have attached a diff off of the\n> 'maint' branch for this, however it seems to apply cleanly\n> to 'master' as well.\n> \n> Thank you for your patience.\n\nThanks Alfred,\n\nI've removed the '.' from the commit subject, signed-off,\nand pushed to my repo for Junio:\n\nThe following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:\n\n Git 2.9 (2016-06-13 10:42:13 -0700)\n\nare available in the git repository at:\n\n git://bogomips.org/git-svn.git svn-propset-doc\n\nfor you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:\n\n Document the 'svn propset' command (2016-06-15 20:11:22 +0000)\n\n----------------------------------------------------------------\nAlfred Perlstein (1):\n Document the 'svn propset' command\n\n Documentation/git-svn.txt | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)\n"},{"id":"289318","messageId":"xmqqvb1a5hlf.fsf@gitster.mtv.corp.google.com","threadId":"42585","inReplyTo":"20160615201556.GA6303@dcvr.yhbt.net","subject":"Re: [PATCH] Document the 'svn propset' command.","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-06-15T20:21:00Z","receivedAt":"2016-06-16T06:55:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Wong writes:\n\n> Thanks Alfred,\n>\n> I've removed the '.' from the commit subject, signed-off,\n> and pushed to my repo for Junio:\n>\n> The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:\n>\n> Git 2.9 (2016-06-13 10:42:13 -0700)\n>\n> are available in the git repository at:\n>\n> git://bogomips.org/git-svn.git svn-propset-doc\n>\n> for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:\n>\n> Document the 'svn propset' command (2016-06-15 20:11:22 +0000)\n\nI actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:\nsupport for git-svn propset, 2014-12-07) so that it could go to\nolder maintenance tracks.\n\nI will pick up your Reviewed-by: and redo it. Thanks.\n"},{"id":"289320","messageId":"FBF1CB04-C2EE-4675-8FC0-69A48410BB48@freebsd.org","threadId":"42585","inReplyTo":"xmqqvb1a5hlf.fsf@gitster.mtv.corp.google.com","subject":"Re: [PATCH] Document the 'svn propset' command.","fromName":"Alfred Perlstein","fromEmail":"alfred@freebsd.org","sentAt":"2016-06-15T20:24:42Z","receivedAt":"2016-06-16T06:55:53Z","isPatch":true,"sender":{"key":"alfred@freebsd.org","avatar":"https://avatars.githubusercontent.com/u/629072?v=4"},"body":"\n\n> On Jun 15, 2016, at 1:21 PM, Junio C Hamano wrote:\n> \n> Eric Wong writes:\n> \n>> Thanks Alfred,\n>> \n>> I've removed the '.' from the commit subject, signed-off,\n>> and pushed to my repo for Junio:\n>> \n>> The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:\n>> \n>> Git 2.9 (2016-06-13 10:42:13 -0700)\n>> \n>> are available in the git repository at:\n>> \n>> git://bogomips.org/git-svn.git svn-propset-doc\n>> \n>> for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:\n>> \n>> Document the 'svn propset' command (2016-06-15 20:11:22 +0000)\n> \n> I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:\n> support for git-svn propset, 2014-12-07) so that it could go to\n> older maintenance tracks.\n> \n> I will pick up your Reviewed-by: and redo it. Thanks.\n> \n\nThank you, always great working with the git project! \n\n-Alfred \n"},{"id":"289321","messageId":"BD0842E2-2AA2-40EB-B1FC-2097A1B7BF39@apple.com","threadId":"42585","inReplyTo":"FBF1CB04-C2EE-4675-8FC0-69A48410BB48@freebsd.org","subject":"Re: [PATCH] Document the 'svn propset' command.","fromName":"Joseph Pecoraro","fromEmail":"pecoraro@apple.com","sentAt":"2016-06-15T20:32:07Z","receivedAt":"2016-06-16T06:55:53Z","isPatch":true,"sender":{"key":"pecoraro@apple.com","avatar":null},"body":"> On Jun 15, 2016, at 1:24 PM, Alfred Perlstein wrote:\n> \n>> On Jun 15, 2016, at 1:21 PM, Junio C Hamano wrote:\n>> \n>> Eric Wong writes:\n>> \n>>> Thanks Alfred,\n>>> \n>>> I've removed the '.' from the commit subject, signed-off,\n>>> and pushed to my repo for Junio:\n>>> \n>>> The following changes since commit 05219a1276341e72d8082d76b7f5ed394b7437a4:\n>>> \n>>> Git 2.9 (2016-06-13 10:42:13 -0700)\n>>> \n>>> are available in the git repository at:\n>>> \n>>> git://bogomips.org/git-svn.git svn-propset-doc\n>>> \n>>> for you to fetch changes up to f3961b2eba8ba6aa2fddc827ddf5c26b41391872:\n>>> \n>>> Document the 'svn propset' command (2016-06-15 20:11:22 +0000)\n>> \n>> I actually queued it directly on top of v2.3.0-rc0~32^2 (git-svn:\n>> support for git-svn propset, 2014-12-07) so that it could go to\n>> older maintenance tracks.\n>> \n>> I will pick up your Reviewed-by: and redo it. Thanks.\n>> \n> \n> Thank you, always great working with the git project! \n> \n> -Alfred \n\nThanks for addressing this!\n\n- Joe\n"}]}