threads / patch / 42336

patchattr: update a stale comment on "struct match_attr"

Subject: [PATCH] attr: update a stale comment on "struct match_attr"

## tl;dr

One message between May 15, 2016 and May 15, 2016. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Junio C Hamano· May 15, 2016, 22:59 UTC · lore

When 82dce998 (attr: more matching optimizations from .gitignore, 2012-10-15) changed a pointer to a string "*pattern" into an embedded "struct pattern" in struct match_attr, it forgot to update the comment that describes the structure.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 attr.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Show changes to attr.c +2 −3
diff --git a/attr.c b/attr.c
index eec5d7d..94b27f4 100644
--- a/attr.c
+++ b/attr.c
@@ -131,9 +131,8 @@ struct pattern {
  * If is_macro is true, then u.attr is a pointer to the git_attr being
  * defined.
  *
- * If is_macro is false, then u.pattern points at the filename pattern
- * to which the rule applies.  (The memory pointed to is part of the
- * memory block allocated for the match_attr instance.)
+ * If is_macro is false, then u.pat is the filename pattern to which the
+ * rule applies.
  *
  * In either case, num_attr is the number of attributes affected by
  * this rule, and state is an array listing them.  The attributes are
-- 
2.8.2-748-gfb85f76

← back to recent threads