{"thread":{"id":"42336","subject":"[PATCH] attr: update a stale comment on \"struct match_attr\"","startedAt":"2016-05-15T22:59:08Z","lastAt":"2016-05-15T22:59:08Z","messageCount":1,"participants":["Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"286617","messageId":"xmqq60uf3p37.fsf@gitster.mtv.corp.google.com","threadId":"42336","inReplyTo":null,"subject":"[PATCH] attr: update a stale comment on \"struct match_attr\"","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2016-05-15T22:59:08Z","receivedAt":"2016-05-15T22:59:08Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"When 82dce998 (attr: more matching optimizations from .gitignore,\n2012-10-15) changed a pointer to a string \"*pattern\" into an\nembedded \"struct pattern\" in struct match_attr, it forgot to update\nthe comment that describes the structure.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n attr.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)\n\ndiff --git a/attr.c b/attr.c\nindex eec5d7d..94b27f4 100644\n--- a/attr.c\n+++ b/attr.c\n@@ -131,9 +131,8 @@ struct pattern {\n  * If is_macro is true, then u.attr is a pointer to the git_attr being\n  * defined.\n  *\n- * If is_macro is false, then u.pattern points at the filename pattern\n- * to which the rule applies.  (The memory pointed to is part of the\n- * memory block allocated for the match_attr instance.)\n+ * If is_macro is false, then u.pat is the filename pattern to which the\n+ * rule applies.\n  *\n  * In either case, num_attr is the number of attributes affected by\n  * this rule, and state is an array listing them.  The attributes are\n-- \n2.8.2-748-gfb85f76\n"}]}