threads / discuss / 41895

RPM spec file broken by README.md

Subject: RPM spec file broken by README.md

## tl;dr

4 messages between Apr 1, 2016 and Apr 1, 2016.

replies: 3people: 3as markdown or json

Ron Isaacson· Apr 1, 2016, 05:35 UTC · lore

Hi everyone,

I've noticed that "make rpm" is failing for 2.8.0 because README was replaced with README.md. This line in git.spec is the culprit:

%doc README COPYING Documentation/*.txt

Would it be possible to change this to README.md to match the source tree? The rpm packages build just fine with that change. Thank you very much!

  - Ron

Matthieu Moy· Apr 1, 2016, 07:10 UTC · re: Ron Isaacson · lore

[PATCH] git.spec: use README.md, not README

The file was renamed in 4ad21f5 (README: use markdown syntax, 2016-02-25), but that commit forgot to update git.spec.in.

Reported-by: Ron Isaacson <isaacson.ljits@gmail.com>
Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
---
 git.spec.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/git.spec.in b/git.spec.in
index d61d537..bfd1cfb 100644
--- a/git.spec.in
+++ b/git.spec.in
@@ -146,7 +146,7 @@ rm -rf $RPM_BUILD_ROOT
 %files -f bin-man-doc-files
 %defattr(-,root,root)
 %{_datadir}/git-core/
-%doc README COPYING Documentation/*.txt
+%doc README.md COPYING Documentation/*.txt
 %{!?_without_docs: %doc Documentation/*.html Documentation/howto}
 %{!?_without_docs: %doc Documentation/technical}
 %{_sysconfdir}/bash_completion.d

-- 
2.7.2.334.g35ed2ae.dirty

Christian Couder· Apr 1, 2016, 11:23 UTC · re: Ron Isaacson · lore

Re: RPM spec file broken by README.md

Hi!

On Fri, Apr 1, 2016 at 7:35 AM, Ron Isaacson <isaacson.ljits@gmail.com> wrote:

Show 10 quoted lines

> Hi everyone,
>
> I've noticed that "make rpm" is failing for 2.8.0 because README was
> replaced with README.md. This line in git.spec is the culprit:
>
> %doc README COPYING Documentation/*.txt
>
> Would it be possible to change this to README.md to match the source
> tree? The rpm packages build just fine with that change. Thank you
> very much!

Thanks for this bug report.

Would you care to send a patch?

Christian Couder· Apr 1, 2016, 11:24 UTC · re: Christian Couder · lore

Re: RPM spec file broken by README.md

On Fri, Apr 1, 2016 at 1:23 PM, Christian Couder <christian.couder@gmail.com> wrote:

Show 17 quoted lines

> Hi!
>
> On Fri, Apr 1, 2016 at 7:35 AM, Ron Isaacson <isaacson.ljits@gmail.com> wrote:
>> Hi everyone,
>>
>> I've noticed that "make rpm" is failing for 2.8.0 because README was
>> replaced with README.md. This line in git.spec is the culprit:
>>
>> %doc README COPYING Documentation/*.txt
>>
>> Would it be possible to change this to README.md to match the source
>> tree? The rpm packages build just fine with that change. Thank you
>> very much!
>
> Thanks for this bug report.
>
> Would you care to send a patch?

Ooops, it looks like Matthieu already sent a patch. Sorry for the noise.